Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions as a supported form of Continuous Integration (CI) #96

Closed
DilumAluthge opened this issue Sep 23, 2019 · 11 comments · Fixed by #61
Closed

Add GitHub Actions as a supported form of Continuous Integration (CI) #96

DilumAluthge opened this issue Sep 23, 2019 · 11 comments · Fixed by #61
Labels
Plugin Idea A proposal for a feature that can be accomplished with a plugin

Comments

@DilumAluthge
Copy link
Member

GitHub Actions will reach general availability on November 13. It would be great if, by that date, PkgTemplates was able to set up GitHub Actions for continuous integration (CI).

Unfortunately, I know very little about GitHub Actions. But I know that @davidanthoff has been working on Julia + GitHub Actions. Maybe he can provide some guidance.

@christopher-dG christopher-dG added the Plugin Idea A proposal for a feature that can be accomplished with a plugin label Sep 23, 2019
@christopher-dG
Copy link
Member

That should be an easy deadline to hit, seeing as https://github.com/julia-actions has most of the work done.

@davidanthoff
Copy link

I think we are still trying to figure out the best way to do this with GitHub Actions, any feedback on what we have so far would be great!

@christopher-dG
Copy link
Member

Sounds good, I'll have a look and open issues if I notice anything.

@DilumAluthge
Copy link
Member Author

@christopher-dG Out of curiosity, will PR #61 fix this issue?

@carstenbauer
Copy link

Since I couldn't find it in the docs, is it now possible to set up GitHub workflow based CI through PkgTemplates?

@christopher-dG
Copy link
Member

On master branch; I need to re-add the interactive code before tagging a new release.
You can browse docs for #107 here, which is master + TagBot + CompatHelper.

@carstenbauer
Copy link

carstenbauer commented Nov 12, 2019

AFAICS, there is no support for Github CI + custom registry, though. Basically the latter simply requires an extra step in the workflow:

- name: Add CustomRegistry
  run: julia -e 'using Pkg; Pkg.Registry.add(Pkg.RegistrySpec(url="http://github.com/JuliaRegistries/General")); Pkg.Registry.add(Pkg.RegistrySpec(url="http://github.com/owner/CustomRegistry")); Pkg.Registry.status()'
  shell: bash

Note that one has to set shell: bash as otherwise Windows runs will fail. Also, one cannot test on Julia < 1.1 this way, since, as has been pointed out by @DilumAluthge above, the Pkg.Registry stuff requires Julia >= 1.1.

Should I open a separate issue for this?

@christopher-dG
Copy link
Member

You're right, that support isn't there right now (but the file argument is as a stopgap).
Good idea to open a new issue.

@NHDaly
Copy link

NHDaly commented Jul 26, 2022

Now that it's been a while, can we set the GitHub Actions CI as one of the default plugins that get added to every package?

@nickrobinson251
Copy link
Collaborator

Now that it's been a while, can we set the GitHub Actions CI as one of the default plugins that get added to every package?

Seems reasonable to me! Made an issue to track it #357

Can you be tempted to make a PR, @NHDaly ?

@NHDaly
Copy link

NHDaly commented Aug 8, 2022

Thanks! 😅 probably not in the next few weeks. maybe i'll have a look again after that if I am available. Feel free to ping me if nothing happens on that other issue. Hopefully a new contributor is excited to tackle it themselves! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plugin Idea A proposal for a feature that can be accomplished with a plugin
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants