-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plugins for TagBot and CompatHelper #107
Conversation
May I add that it would be great if these plugins were to support custom registries right from the start. For example, they could take a
Assuming that |
Codecov Report
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 91.84% 92.04% +0.19%
==========================================
Files 15 17 +2
Lines 319 327 +8
==========================================
+ Hits 293 301 +8
Misses 26 26
Continue to review full report at Codecov.
|
I'm not going to do the CompatHelper one for now because it wouldn't have a very nice API ( |
If we were to restrict ourselves to just a single custom repository I don't think the API would have to be like this. As I said above, we could use the same API as for TagBot: from "owner/registryrepo" we can generate the URL "http://github.com/owner/registryrepo/Registry.toml", where we find the name and uuid information of the custom registry. |
Yeah I'm cool with that API. But since that requires HTTP, I'm going to wait on implementing it until we do more HTTP-related things (#79). |
aa4cbf9
to
aa13660
Compare
This is good to go, I'm just thinking about how I want to deal with JuliaRegistries/TagBot#36 (the TagBot template will change if I do the underscored inputs). |
@christopher-dG Just FYI- I just registered CompatHelper version 1.0.0. It will be automerged within an hour. Since the CompatHelper API is stable, how do you feel about it making it a default? |
Yeah I'm cool with defaulting it, seems like it's been very well-received by the community. |
TODO: Handle the Manifest.toml updating stuff.
aa13660
to
cc2fee9
Compare
I'm gonna go ahead and merge this tonight (after I merge some stuff in TagBot). Custom registries are not supported in the default CompatHelper template, but you can bring your own if you need for now. Default support will come when CompatHelper has a nice config option for it. |
Closes #105
TagBot is a default plugin due to its wide adoption, but I think I will wait until CompatHelper hits 1.0 before making it default.