Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EUPL-1.2+ (EN) license #63

Merged
merged 3 commits into from
Mar 11, 2019
Merged

Add EUPL-1.2+ (EN) license #63

merged 3 commits into from
Mar 11, 2019

Conversation

SaschaMann
Copy link
Contributor

@SaschaMann SaschaMann commented Mar 10, 2019

Add the European Union Public Licence v1.2 to the templates.


Since this licence exists and is valid in 22 languages, and devs can choose their preferred one, I'd also like to add those versions. (mostly because I also need the German version in addition to the English one for some of my own projects and it'd make my life easier 😛)
However, it would blow up the interactive prompt, so I decided against it. If you have a suggestion on how to get around that issue, I'd implement it and submit another PR.

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          13       13           
  Lines         372      372           
=======================================
  Hits          364      364           
  Misses          8        8
Impacted Files Coverage Δ
src/licenses.jl 75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb169a...3925d26. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 10, 2019

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   97.84%   97.84%           
=======================================
  Files          13       13           
  Lines         372      372           
=======================================
  Hits          364      364           
  Misses          8        8
Impacted Files Coverage Δ
src/licenses.jl 75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb169a...99793f7. Read the comment docs.

a new version of the EUPL, as long as they provide the rights granted in Article 2 of this Licence and protect the
covered Source Code from exclusive appropriation.
All other changes or additions to this Appendix require the production of a new EUPL version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you drop this empty line please?

@christopher-dG
Copy link
Member

Hm, interesting question on how we can enable multiple languages. This would be easily accomplished with a plugin which took a language argument, but I don't recommend implementing anything until #61 is finished as many internal APIs are changing.

@SaschaMann
Copy link
Contributor Author

Removed the extra line.

I'll take another look at adding the other languages once #61 is merged then.

@SaschaMann
Copy link
Contributor Author

Forgot that I added (EN) in the full name. Removed it, it doesn't make sense as long as there's only one version in the package.

@christopher-dG
Copy link
Member

Great, thanks 🙂

@christopher-dG christopher-dG merged commit 6f00575 into JuliaCI:master Mar 11, 2019
@SaschaMann SaschaMann deleted the eupl-license branch March 11, 2019 14:51
@SaschaMann
Copy link
Contributor Author

Thanks for the quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants