Skip to content

classic_backporting todo tbc commits

Lukas edited this page Jul 10, 2014 · 1 revision

Commits that must be backported from C-MaNGOS TBC (branch cleaned_tbc_history)


This file stores commits that should be backported from C-MaNGOS-TBC to C-MaNGOS-Classic
The content of this file is created with the update-commit-log.sh helper file

Just delete the commits that are not required for backporting.
Also feel free to paste notes here about other missing backports


This has no application in classic content. Keep it here as reference in case it was needed to get code in sync!
TBCCOMMIT 237f9ab by VladimirMangos (commiter TheLuda) "

 [s1326] Implement in proper way ITEM_SPELLTRIGGER_ON
STORE (5) "

DestroyItemWithOnStoreSpell does not exist in Classic – Missing another backport?
TBCCOMMIT 6605f7a by VladimirMangos (commiter TheLuda)

 [s1327] More consitence use m
target for DestroyItemWithOnStoreSpell call in aura.

Xfurry: not sure if the following is required
tbc: aace559 * virusav (committer Salja)

[s1457] Remove check for quest_template if QuestSort and SkillId match

Xfurry: Transporter commits – require additional research
stfx: Could only think of being used for pets so that they dont fall off the transport when it starts moving – but its impossible to say without npc-on-transport being finished

  • tbc: 252e045 * kid10 (committer stfx)
    [s1685] Implement abstract classes for transporter
      94.6% src/game/
       3.2% win/VC100/
    
  • tbc: 1c71e40 * kid10 (committer stfx)
    [s1686] Add a TransportInfo class to WorldObjects
      62.8% src/game/movement/
      32.0% src/game/
       5.1% src/shared/
    
  • tbc: ffd46e6 * kid10 (committer Xfurry)
    [s1734] Add abstract Board/Unboard Passenger functions to TransportBase
      95.7% src/game/
       4.2% src/shared/
    
  • tbc: b8e5466 * evil-at-wow (committer Xfurry)
    Fix build on Linux/GCC: hash_map's 'erase' member takes an iterator, so passing it a const_iterator is a no go.
     100.0% src/game/
    

End of transporter commits


Xfurry: Disengage commits – not sure if apply to classic

  • tbc: 55d1fb6 * Den (committer Xfurry)
    [s1768] Fix Spell::CheckCast for Disengage
      82.3% src/game/
      17.6% src/shared/
    
  • tbc: bd5ce36 * rsa (committer Xfurry)
    [s1771] Make check for Disengange like spells of [12215] more generic
      90.0% src/game/
       9.9% src/shared/
    
  • tbc: 254f1a0 * Schmoozerd (committer Xfurry)
    [s1828] Use SpellFocus check for all Spells
      84.3% src/game/
      15.6% src/shared/

stfx: On 1.12 I am pretty sure that SMSG_PET_CAST_FAILED doesnt have the added cast_count but then again neither has SMSG_CAST_FAILED. Maybe those two cant use the same structure on 1.12 as its done on master/tbc.

End of other misc commits


Clone this wiki locally