Deploy Checklist: New Expensify 2021-12-08

[OSBotify]

Release Version: 1.1.19-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

• fix: LoginPage for wide screens #6137

  • QA
  • Accessibility

• Added frequently used emojis support #6498

  • QA
  • Accessibility

• Update Terms and Fees step to match latest requirements #6573

  • QA
  • Accessibility

• [No QA] Update ESLint version #6583

  • QA
  • Accessibility

• Disable landscape view on phones #6608

  • QA
  • Accessibility

• Revert "unknown report check" due to regression - unable to create group chats #6615

  • QA
  • Accessibility

• [NO QA]Sign commits for @OSBotify #6629

  • QA
  • Accessibility

• [CP STG] Revert WorkspaceBankAccount page changes #6630

  • QA
  • Accessibility

• [CP STAG] Fix FormData issue #6631

  • QA
  • Accessibility

• P2P Enable adding deposit account as payment method #6638

  • QA
  • Accessibility

• Fix warning, re-fix 'Welcome screen is not fully displayed on large screen iPad' issue #6639

  • QA
  • Accessibility

Deploy Blockers:

• iOS - Payment - Save and continue button hidden behind keypad #6666
• mWeb - iPad 7- Welcome screen is not fully displayed on large screen iPad #6667
• Missing avatars in the center of the group conversation #6675

cc @Expensify/applauseleads

[MelvinBot]

📣 @applausebot You have been assigned to this job by @OSBotify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[roryabraham]

Nice short checklist here 😄

[isagoico]

My favorites ❤️

[roryabraham]

@isagoico Feel free to lock the checklist and begin QA as soon as you're ready.

[mvtglobally]

Starting QA

[roryabraham]

The fix for #6667 was deployed in 1.1.19-1, and the fix for #6666 was deployed in 1.1.19-2, so feel free to retest those whenever you're ready.

[roryabraham]

Manually CPing #6684 to staging in 1.1.19-4 to fix #6675 and also to test #6655.

[roryabraham]

1.1.19-4 is deploying here. Once that's done we should be able to retest all existing deploy blockers.

[mvtglobally]

Regression is almost complete. Few re-tests in progress

Deploy blockers found (we are re-testing)

• iOS - Payment - Save and continue button hidden behind keypad iOS - Payment - Save and continue button hidden behind keypad #6666
• mWeb - iPad 7- Welcome screen is not fully displayed on large screen iPad mWeb - iPad 7- Welcome screen is not fully displayed on large screen iPad #6667
• Missing avatars in the center of the group conversation Missing avatars in the center of the group conversation #6675

Comments added
#6608 (comment)

Issues logged
#6676
#6681
#6685
#6688
#6691
#6689
#6669

[roryabraham]

Thanks @mvtglobally, keep me posted with the status of deploy blocker retests.

[roryabraham]

Any update here? Seems like we should be almost ready-to-go here.

[mvtglobally]

@roryabraham, Regression is almost done.
Blockers are re-tested and passed. I checked off all PRs and issues #6666 , #6667

We had a bit inconsistent notifications behavior on Android. Team is trying to re-verify "Receive notification while app is backgrounded" steps. We should be able to close this in the next hour.

[mvtglobally]

@roryabraham We are able to repro this #5022 today. I dont think its a deploy blocker as this is still open.

Regarding #6675 We are getting very mixed results.
Few testers still able to repro on build 1.1.19-4. I am not able to repro on any device. Can you also double check?

https://user-images.githubusercontent.com/43995119/145620704-05838316-adc0-4841-a5fa-bedf768b3f8e.mp4
https://user-images.githubusercontent.com/43995119/145620894-bf3ad384-c2d1-450f-850e-f13b86ab0444.mp4

[roryabraham]

Shoot, I was able to reproduce on #6675 iOS 1.1.19-4 😞 Going to reopen and look into it some more.

[roryabraham]

Going to demote #6675 from deploy blocker to KI. @mvtglobally Please include it in your weekly retests.

[roryabraham]