Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-render ReportActionsView when report icons change #6684

Merged
merged 1 commit into from
Dec 10, 2021

Conversation

roryabraham
Copy link
Contributor

Fixed Issues

$ #6675

Tests / QA Steps

  1. Create a new group with at least 4 members.
  2. Verify that the empty state avatars are visible:

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

Desktop

iOS

Android

@roryabraham roryabraham requested a review from a team December 9, 2021 22:34
@roryabraham roryabraham self-assigned this Dec 9, 2021
@roryabraham
Copy link
Contributor Author

Going to want to manually CP this to staging so that we can test #6655

@MelvinBot MelvinBot requested review from nkuoch and removed request for a team December 9, 2021 22:34
Copy link
Contributor

@deetergp deetergp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean fix 👍

@deetergp deetergp merged commit 46d2b35 into main Dec 10, 2021
@deetergp deetergp deleted the Rory-FixGroupAvatars branch December 10, 2021 00:23
@deetergp
Copy link
Contributor

@nkuoch I went ahead and merged it since it's a DeployBlocker for NewDot.

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Dec 10, 2021
Re-render ReportActionsView when report icons change

(cherry picked from commit 46d2b35)
@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @deetergp in version: 1.1.19-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants