Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA]Sign commits for @OSBotify #6629

Merged
merged 3 commits into from
Dec 8, 2021
Merged

[NO QA]Sign commits for @OSBotify #6629

merged 3 commits into from
Dec 8, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

Second try at signing @OSBotify's commit's for creating new versions and cherry picks. This code was copied from these five reverted PRs:
1. #6379
2. #6377
3. #6374
4. #6371
5. #6368

Fixed Issues

Related https://github.com/Expensify/Expensify/issues/149007 (Doesn't fix 100% yet)

Tests

  1. Merge this PR
  2. Verify the version created is signed
  3. Verify no other GH actions have issues

@AndrewGable AndrewGable requested a review from a team as a code owner December 7, 2021 21:32
@AndrewGable AndrewGable self-assigned this Dec 7, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@AndrewGable AndrewGable changed the title Sign commits for @OSBotify [NO QA]Sign commits for @OSBotify Dec 7, 2021
@MelvinBot MelvinBot requested review from luacmartins and removed request for a team December 7, 2021 21:32
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, are we just going to wait and see if manual CP's are broken when we require GPG-signed commits, and then address that when it comes up?

.github/workflows/deploy.yml Outdated Show resolved Hide resolved
luacmartins
luacmartins previously approved these changes Dec 7, 2021
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should address Rory's comment though.

Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndrewGable I think this looks good but we are very close to a prod deploy here today and I want to get that out before we merge this.

Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roryabraham roryabraham merged commit e9ba4e8 into main Dec 8, 2021
@roryabraham roryabraham deleted the andrew-sign-v2 branch December 8, 2021 19:58
@roryabraham
Copy link
Contributor

@roryabraham
Copy link
Contributor

Looks like it all worked in this case and the commits were signed:

image

@AndrewGable
Copy link
Contributor Author

🥳

@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to staging by @roryabraham in version: 1.1.18-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants