Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO QA]Import from the GPG key from the right directory #6371

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

AndrewGable
Copy link
Contributor

Details

In #6368 we added the GPG key needed to sign commits, but the GH action failed to import the key. This was because we were trying to import from the wrong directory, this PR fixes that.

Fixed Issues

Fixes broken GH Action https://github.com/Expensify/App/runs/4268916534?check_suite_focus=true

Tests

  1. CP this PR and verify the version commit is signed correctly

@AndrewGable AndrewGable self-assigned this Nov 19, 2021
@AndrewGable AndrewGable requested a review from a team as a code owner November 19, 2021 20:37
@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from madmax330 and removed request for a team November 19, 2021 20:38
@Jag96
Copy link
Contributor

Jag96 commented Nov 19, 2021

Skipping unnecessary tests to fix gh actions

@Jag96 Jag96 merged commit 5b01814 into main Nov 19, 2021
@Jag96 Jag96 deleted the andrew-sign-directory branch November 19, 2021 20:42
@botify
Copy link

botify commented Nov 19, 2021

@Jag96 looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@Jag96 Jag96 removed the Emergency label Nov 19, 2021
@AndrewGable AndrewGable changed the title Import from the GPG key from the right directory [NO QA]Import from the GPG key from the right directory Nov 19, 2021
@AndrewGable
Copy link
Contributor Author

This is working now, still some other bugs to sort out, but it's getting closer.

Screen Shot 2021-11-19 at 3 03 20 PM

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Jag96 in version: 1.1.15-18 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.16-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants