Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Payment - Save and continue button hidden behind keypad #6666

Closed
kbecciv opened this issue Dec 9, 2021 · 11 comments
Closed

iOS - Payment - Save and continue button hidden behind keypad #6666

kbecciv opened this issue Dec 9, 2021 · 11 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kbecciv
Copy link

kbecciv commented Dec 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


The bug was found when executing the PR #6638

Action Performed:

  1. Launch the app and login
  2. Navigate to Settings > Payments > Add payment method and select "Bank account"
  3. Verify the Plaid modal is presented and login with Chase test credentials.
  4. Select an account from the list
  5. Enter incorrect or correct password

Expected Result:

Save and continue button displayed above the keypad or page scrollable to tap the button

Actual Result:

Save and continue button hidden by keypad and unable to scroll the page. Only option is to dismiss the keypad to continue.

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • iOS

Version Number: 1.1.19-0

Reproducible in staging?: YES

Reproducible in production?: No

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Video

The bug was found when executing the PR #6638

Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added DeployBlockerCash This issue or pull request should block deployment AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Dec 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @alexpensify (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Dec 9, 2021
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 9, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alexpensify alexpensify removed their assignment Dec 9, 2021
@kbecciv kbecciv added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 and removed Engineering Hourly KSv2 labels Dec 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @flaviadefaria (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Dec 9, 2021
@MelvinBot
Copy link

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv kbecciv added the Hourly KSv2 label Dec 9, 2021
@kavimuru kavimuru removed the Daily KSv2 label Dec 9, 2021
@bondydaa
Copy link
Contributor

bondydaa commented Dec 9, 2021

as a work around can you dismiss the keyboard to see the button? I agree this should be fixed but not sure this needs to be an hourly if we have a work around.

@bondydaa bondydaa removed their assignment Dec 9, 2021
@bondydaa
Copy link
Contributor

bondydaa commented Dec 9, 2021

cc @nickmurray47 not sure if this is related to the plaid/oauth changes or not.

@parasharrajat
Copy link
Member

Was it working before the PR?

@Jag96
Copy link
Contributor

Jag96 commented Dec 9, 2021

OOO today, auto assigning another engineer to help triage this one

@Jag96 Jag96 removed their assignment Dec 9, 2021
@nickmurray47
Copy link
Contributor

I think this could be related to the personal bank account changes since I know we added the password field there. Could be that the new field is pushing out the keyboard? Can try to take a look although my XCode environment got absolutely borked for some reason yesterday.

@nickmurray47
Copy link
Contributor

Ah, think I know what we could do here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests