Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - iPad 7- Welcome screen is not fully displayed on large screen iPad #6667

Closed
kavimuru opened this issue Dec 9, 2021 · 4 comments
Closed
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review

Comments

@kavimuru
Copy link

kavimuru commented Dec 9, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue was found when executing #6639

Action Performed:

  1. Open the sign-in page
  2. Make sure the image on the right side is displayed in full

Expected Result:

Log in screen is displayed without any visual issues.

Actual Result:

Welcome screen is not fully displayed on large screen iPad

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Mobile Web iPad 7 size is 10.2in

Version Number: 1.1.19-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos:

Bug5365947_IPad_Safari_6639.mp4

Issue was found when executing #6639

Expensify/Expensify Issue URL:

Issue reported by: Applause

Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Dec 9, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Dec 9, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@roryabraham
Copy link
Contributor

This seems really weird – why is the browser not adjusting to the orientation change in that video?

@roryabraham
Copy link
Contributor

Got a fix up 👍

@roryabraham roryabraham added the Reviewing Has a PR in review label Dec 9, 2021
@botify botify closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2 Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants