Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP STAG] Fix FormData issue #6631

Merged
merged 4 commits into from
Dec 7, 2021
Merged

[CP STAG] Fix FormData issue #6631

merged 4 commits into from
Dec 7, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Dec 7, 2021 •
edited
Loading

Details

Fixed Issues

$ #6528

Tests / QA Steps

  1. Create workspace
  2. Navigate to Workspace members page on iOS, Android, and Web
  3. Verify members are visible on all platforms

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

2021-12-07_12-58-58

Android

2021-12-07_12-59-28

@marcaaron marcaaron self-assigned this Dec 7, 2021
@marcaaron marcaaron requested a review from a team as a code owner December 7, 2021 22:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@MelvinBot MelvinBot requested review from Beamanator and removed request for a team December 7, 2021 22:45
@marcaaron marcaaron requested a review from Jag96 December 7, 2021 22:47
marcaaron
marcaaron commented Dec 7, 2021
View reviewed changes
src/libs/Network.js Outdated Show resolved Hide resolved
@marcaaron
Copy link
Contributor Author

Updated.

@Jag96 Jag96 merged commit b86926d into main Dec 7, 2021
@Jag96 Jag96 deleted the marcaaron-formDataHatesArrays branch December 7, 2021 23:50
github-actions bot pushed a commit that referenced this pull request Dec 7, 2021
@Jag96
Merge pull request #6631 from Expensify/marcaaron-formDataHatesArrays
f3d473f 
[CP STAG] Fix FormData issue

(cherry picked from commit b86926d)
@OSBotify OSBotify mentioned this pull request Dec 7, 2021
Merged
@roryabraham roryabraham mentioned this pull request Dec 8, 2021
Closed
95 tasks
@OSBotify OSBotify mentioned this pull request Dec 8, 2021
Closed
25 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Dec 8, 2021

🚀 Deployed to staging by @Jag96 in version: 1.1.18-4 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Christinadobrzyn Christinadobrzyn mentioned this pull request Dec 9, 2021
Closed
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify OSBotify mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

@Beamanator Beamanator Awaiting requested review from Beamanator

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcaaron @OSBotify @Jag96