Deploy Checklist: New Expensify 2024-07-15

[github-actions]

Release Version: 9.0.7-8
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Improve location permission handling #39875
• fix: [Violations] Distance - Incorrect error message when distance amount is changed to smaller amount. #41649
• fix: tapping assignee and mark as complete quickly navigates to not found page #41667
• Remove UpdateFrequentlyUsedEmojis and support new frequentlyUsedEmojis NVP format #42208
• Reset amount on reset button click #42897
• Policy category - Add GL Code #43149
• Policy category - Add Payroll Code #43151
• Tags - Add GL Code #43155
• fix: split amount is put into a second line #43624
• fix: QBO - Required remains enabled when all tags are disabled #43813
• fix: convert distance value to meters if necessary #43819
• Fix: Workspace member has option to edit categories #43975
• Empty State Component for Search #44137
• [NoQA] E2E test. Linking, same page  #44286
• fix: do not refresh draft txn after redirect #44363
• fix: IOU - On entering amount with decimals, 3rd decimal 0 is added in IOU confirmation page. #44416
• [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends #44483
• Fix: Pay someone quick action text is truncated differently in mweb & Android #44547
• Fix: User is able to leave public room when user is not logged in #44560
• Fix paid system message thread does not show up on LHN #44594
• DOCS: Second new folder, article rewrites, article renaming, redirects, and new articles #44645
• fix: Search - RHP closes or returns to transaction thread depending on which field is edited. #44662
• Start showing the beginningOfChatHistory in other room types #44667
• fix: update grouped expense on search page #44674
• fix: LHN of self-DM still shows actionable whisper after submitted #44684
• Fixes issue: Bank account personal info isn't accepting characters with umlaut as name #44689
• Remove Report Fields Beta #44695
• Suggestion box for edit input #44720
• Sage intacct export: offline and error #44739
• fix: Distance - Start and Stop labels do not change when dragging one over another. #44748
• Fix inconsistency in dismissing report details RHP when deleting expense with comments #44777
• Hide task report by default #44794
• Change high resolution image with preview #44807
• Fix: Add red dot to one transaction reports #44810
• [Search] Selection Mode for small screens #44820
• Only initialize FullStory after we confirm if this is production #44821
• Fix missing header after reloading page on waypoint screen and go back #44823
• Fix different amount shown in pay buttons between report preview and expense report header #44838
• Sage Intacct connection follow-up #44850
• Add hold option to report detail page for combine report #44880
• fix: safari password autofill does not disappear #44888
• Fix network connection multiple reachablity request #44901
• [ESM] Add conditon for old dot messages #44907
• Delete all linked report when clearing optimistic chat and transaction error #44923
• Fix bottom tab highlight delay #44931
• fix: QBO - Tag status does not change when 'Members must tag all expenses' is updated offline. #44937
• fix: check for leaveroom last action type #44945
• fix: update logic of filtering created actions from transaction thread report #44946
• Bump react-native-live-markdown #44958
• [NO-QA]: Add Card reconciliation account setting #44968
• handle visual viewport scroll incorrect on ios chrome  #44999
• [No QA] Create new Reconciliation Account Settings page #45047
• fix: Show positive amount when manually entering tax amount  #45050
• Fix cursor position resets to start of message on page refresh #45052
• fix: workspace admin aren't listed in 'Preferred exporter' #45059
• [No QA] Issue New Card Bank Accounts Logic #45069
• Fix logic to check if a report is concierge chat #45070
• Add copy report onyx object to clipboard function on dev/staging #45079
• [Payment card / Subscription] Rollout feature: replace Subscriptions menu item #45089
• [HybridApp] Fix explanation modal #45092
• [#Wave-Control: Add NetSuite] Settings Configuration in NewDot: Combine Customers and Jobs Mapping API #45102
• Fix to field on reportListItem #45105
• [NoQA] Allow anonymous users to call updateAutomaticTimezone function #45107
• Create usePaginatedReportActions hook (round 2) #45112
• Fix breadcrumb title text is cut off #45134
• Fix some part of popover isn't clickable when near the desktop header #45135
• Fix route in distance editor doesn't load after fresh sign in #45139
• fix: e2e results not being posted as PR comment #45140
• Update en.ts #45142
• [Search] Display ConfirmModal before deleting expenses #45143
• Update es.ts #45145
• Don't show unhold for expense that is hold because of duplicate #45148
• [No QA] Create new Card Details page #45155
• [NoQA] Feat: Standardize of using plural name for report fields components #45158
• [No QA] [Search v2] [App] Create Search input parser #45161
• Improve performance of Search list #45165
• Fix page stability issue on animation load #45211
• fix: [Payment Card / Subscription] Update the payment card icon in the Subscription tab. #45219
• [No QA] Create getFilters #45221
• fix mentions not copy to clipboard #45233
• Fix hidden member appears in the WS members after changing default contact method #45234
• Fix not found page briefly appear on new workspace #45239
• [Free Trial] [FE] Getting onboarding chat reportID from nvp #45248
• Update Egencia.md #45257
• Create Expensify-Travel-demo-video #45261
• [NoQA] e2e: properly count re-renders in typing test #45292
• Fix money request options show in Concierge chat #45294
• fix: clear duplicated report data #45295
• [NoQA] Fix the send reassure perfromance data action #45296
• Fix export onyx state not working #45298
• Revert "[NoQA] E2E test. Linking, same page " #45302
• Update Unlimited-Virtual-Cards.md #45306
• [NO QA] Fix typo in spanish #45307
• [No QA] Add Yuwen's iPhone 14 to AdHoc #45308
• Fix web maintainVisibleContentPosition with strict mode enabled #45313
• [NO QA] Stop call OpenWorkspaceView on workspace profile page #45318
• Rename Onyx Key #45320
• Fix IOU members page shows empty page #45322
• Revert "Reset amount on reset button click" #45328
• fix: "Continue" button is missing bottom margin #45329
• using report name value to check archived #45330
• Fix: [Payment card / Subscription] When clicking "Change payment", past data still shows on new form #45334
• Only show "unapprove" button on reports in Approved state / status (not paid yet) #45337
• Fix bad translation #45342
• Fix Flakey SubscriptionUtils Test #45351
• Update Request-the-Card.md #45353
• [No QA] Upgrade actions/upload-artifact to drop deprecated version #45358
• Caught a Spanish typo #45359
• fix: Profile: Long email doesn't take full width.  #45367
• fix: check empty array for report participants #45369
• fix: Split - App does not throw an error when saving the empty merchant field. #45371
• fix: disable opacity for report composer #45376
• fix: iOS - Distance - Top left corner of the distance receipt is sharp instead of rounded. #45383
• fix: Connect bank - -1 is pre-filled for the tax ID number when connecting a new bank account. #45402
• [No QA] Add Abdul's device to adhoc #45419
• Check for hybrid app when completing onboarding #45426
• [CP Staging] Fix text wrapping when no option to select #45454
• [CP Staging] optional chaining for optiondata #45508
• Pass -1 as default parent reportID for group chats #45533
• Disable the button when 0 selected #45535

Internal QA:

• Filter out paycheck report on LHN #45186 - @puneetlath

Deploy Blockers:

• [HOLD for payment 2024-07-22] [$500] Android & iOS-Chat - Report flickers, keyboard is dismissed when focus on composer on Android #45152
• [HOLD for payment 2024-07-24] [$250] Profile - App crashes when uploading profile picture #45162
• Categories & Tags - Not here page opens from GL code row #45429
• [HOLD for payment 2024-08-29] [$250] Scan - Settings button does not open location permission settings #45431
• [$250] Search - Report always auto scroll down after editing the expense from RHP #45434
• [HOLD for payment 2024-08-01] [$250] Chat - User mention is not linked and it is not an actual mention when editing message #45435
• Categories - GL code comes back after clearing the field and reopening the category editor #45442
• [HOLD for payment 2024-08-09] [$125] Hold - LHN does not highlight the currently opened expense thread after holding an expense #45443
• [HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] iOS - Search - "No options available for the selected group of expenses." is truncated #45444
• [HOLD for payment 2024-07-24] iOS - Search - Empty modal is shown when tapping on "0 selected" dropdown #45445
• iOS Hold - App returns to Hold - reason page when tapping on back button after holding expense #45446
• [HOLD for payment 2024-08-14] [$250] Search - Delete modal message changes to ".. these expenses" briefly when clicking Cancel #45447
• [$250] New account - Onboarding messages aren't present when selecting "Something else" in the modal #45455
• [PAID] [$250] Expense report - App crashes after exporting expense report to CSV in OD #45457
• [$125] Task - Inconsistency in character limit count shown in mweb and Android. #45458
• [HOLD for payment 2024-08-09] [$250] Expense - Report turns to skeleton after deleting expense with comments offline #45461
• [HOLD for payment 2024-07-25] [HOLD for payment 2024-07-24] Group chat - App crashes when navigating to group details page after creating the group #45466
• [HOLD for payment 2024-08-14] [$250] Distance - "Add stop" button is shown when Start and Stop points are empty #45467
• [$250] Web/Desktop - Chat - Focus is lost after deleting a message from edit mode #45472
• Categorize -Blank workspace selection page when existing workspace has disabled all categories #45478
• [HOLD for payment 2024-07-30][$250] Deep-link - Infinite skeleton loader appears when navigating to non-existing profile #45486
• [HOLD for payment 2024-07-24] Old Dot redirection - App crashes when redirected from OD when user ID ends with even number #45492
• [$250] Search - App closes RHP instead of returning to report after deleting expense with comments #45505
• Android - App crashes when inviting a secondary email to a workspace #45506
• [HOLD for payment 2024-08-01] Sage Intacct- "Entity" menu is empty and can not be navigated in Sage Intacct #45514
• "free trial ended" is missing from the report after running the given commands #45516
• [HOLD for payment 2024-08-14] [$250] Workspace - Not found page briefly appear on Accounting feature #45517
• [HOLD for payment 2024-08-19] [$250] Send invoice - Hold option is present for invoice and the invoice cannot be held #45518
• Categorizing - Inconsistent app behavior when all categories are deleted offline and online #45519
• [HOLD for payment 2024-08-09] LHN - Long pressing chat does not show "Copy Onx Data" on all platforms #45521

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[tgolen]

Demoted #45431

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.7-3 🚀

[mountiny]

#45162
#45152

Are old blockers where the labels just were not removed

[mvtglobally]

#45306 - PROD QA, Checking off

[mvtglobally]

Regression is at 18% completed only. Will post more detailed summary tomorrow EST

[lakchote]

Demoted #45457 (comment)

[mvtglobally]

Regression is 80% TR with multiple PRs still pending validation

Blockers
#45435
#45444
#45445
#45455
#45458
#45461
#45466
#45467
#45472
#45478
#45486

PRs
#44821 (comment) - Internal QA
#42208 - Is failing, alidating issue and will update
#43149 - is failing #45429. Not an issue, checking off
#43155 - #45429. Not an issue, checking off
#44684 - Is failing #44217. repro in PROD, checking off
#45239 - Is failing, validating issue and will update

[jasperhuangg]

Checking off #45505 NAB

[mvtglobally]

Regression is 95% TR with few PRs still pending validation

Blockers
#45444
#45445
#45455
#45458
#45461
#45466
#45467
#45472
#45478
#45486
#45492
#45505
#45506
#45514
#45516

PRs
#44821 (comment) - Internal QA. Ok to check off?
#42208 - Is failing with the same KI
#44483 - Pending Validation on Desktop
#44594 - Is failing #45203. Repro in PROD, checking off
#44662 - Pending Validation on mWeb
#44674 (comment) - Can you validate internally? We haven't got the feedback
#44684 - Is failing #44217. repro in PROD, checking off
#44720 - Repro old KI. #45076. Checking off
#44850 - Is failing, validating issue and will update
#44931 - is failing with old KI #44587
#45052 - Pending Validation on IOS
#45070 - is failing #45036. repro in PROD, checking off
#45079 (comment) - Checking off
#45102 (comment) - Can you run internally, or help us enable BETA for these
#45143 - Is failing, validating issue and will update
#45239 - Is failing, validating issue and will update
#45248 - Is failing, validating issue and will update
#45295 (comment) - Internal QA
#45313 - Old KI repro #45004. Checking off
#45328 (comment) - Can you validate internally.

[jasperhuangg]

Checking off #45517 NAB

[thienlnam]

There's a single fresh crash SIGSEGV

Appears to be very specific with Missing BuildId 4a4236da5aa01b01890c395d8b3c5269f35bb638, so I don't think we need to block on that

[thienlnam]

[os-botify]

This issue either has unchecked items or has not yet been marked with the :shipit: emoji of approval.
Reopening!

[melvin-bot]

📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[thienlnam]