[$250] Search - App closes RHP instead of returning to report after deleting expense with comments

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.7-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause -Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to any DM
3. Submit two expenses to the user
4. Go to transaction thread of any submitted expense
5. Send a few comments
6. Go to Search
7. Click on the transaction thread with comments
8. Click on the report header
9. Click Delete expense
10. Delete the expense

Expected Result:

App will return to the transaction thread with comments

Actual Result:

App closes the RHP completely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6543949_1721135646891.20240716_210901.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0137d82e1685ebf8ce
• Upwork Job ID: 1813273804933428276
• Last Price Increase: 2024-07-16

Issue Owner

Current Issue Owner: @paultsimura

[melvin-bot]

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

We think that this bug might be related to #wave-collect - Release 1

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0137d82e1685ebf8ce

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

[neil-marcellini]

@jasperhuangg I found that this was modified recently by the PR associated with this issue [$250] Expense - Inconsistency in dismissing report details RHP when deleting expense with comments. I think the current staging behavior might be expected now, but I'm unsure. What do you think? Re-assigning to you since you managed that issue.

[jasperhuangg]

@neil-marcellini Good shout, I think this is the new expected behavior now. @lanitochka17 Are there any integration tests that we need to update?

[bernhardoj]

Yeah, this was agreed in the previous issue to close the details page when deleting a transaction, so we use dismissModal, but this closes the report RHP too. If we want to keep the report RHP open, we can use goBack instead (I can create a follow-up PR if we want to do that).

[melvin-bot]

@jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jasperhuangg]

@bernhardoj No worries, I think if we agreed in the other issue then that should be the new expected behavior. I'll reach out to QA in Slack about updating the regression test.

[jasperhuangg]

Relevant Slack thread for updating regression tests is here

[jasperhuangg]

Bumped the thread

[jasperhuangg]

Resolved in the Slack thread