[HOLD for payment 2024-07-24] [$250] Profile - App crashes when uploading profile picture

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.6.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+uo0710@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Open New Expensify and open profile
2. Tap profile picture and tap "upload photo"
3. Select "choose from gallery" and select and photo

Expected Result:

New profile picture is uploaded

Actual Result:

The app crashes on edit profile picture screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6537951_1720620506102.RPReplay_Final1720620209.mp4

Bug6537951_1720621126292.XRecorder_10072024_095936.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~012a2b40164b680402
• Upwork Job ID: 1811767351593075552
• Last Price Increase: 2024-07-12
• Automatic offers:
• Ahmed-Abdella | Contributor | 103120778
• QichenZhu | Contributor | 103123196

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[yuwenmemon]

Able to reproduce.

[yuwenmemon]

Installing a fresh simulator to give this a test

[yuwenmemon]

Seems like this is coming from reanimated, and the ImageCropView component - but nothing was recently changed about them on the staging version 🤔

[yuwenmemon]

@roryabraham Could this somehow have affected the reanimated patch that we apply on staging?

[yuwenmemon]

We renamed the reanimated patches here and I'm not sure why 🤔 - but it looks awfully sus

[danieldoglas]

I don't think this is related to backend, removing the DeployBlocker tag

[Julesssss]

@roryabraham Could this somehow have affected the reanimated patch that we apply on staging?

Tagging the other PR reviewers who are also familiar with the changes: @AndrewGable @fabioh8010

[yuwenmemon]

Damn, I can't reproduce on dev with the iOS simulator 🤔

[yuwenmemon]

Ah, we renamed them to reflect the current version of reanimated we're using in the app.

[roryabraham]

No, I don't think that PR would have affected the Reanimated patch. All that PR does is fail patch-package if it has an errors or warnings.

For the Reanimated patches, they produced warnings because we had updated the version of Reanimated we were using without updating the patches accordingly. This was a mistake easily missed by reviewers, but my PR would have prevented it. In order to get ✅ on the PR, I had to rename the Reanimated patches to suppress the warning(s).

Why do I say this likely did not cause the crash? Because patch-package was already applying the reanimated patches despite the version mis-match. So app should have been unaffected

[roryabraham]

The warning that I fixed looks like this:

Warning: patch-package detected a patch file version mismatch

  Don't worry! This is probably fine. The patch was still applied
  successfully. Here's the deets:

  Patch file created for

    react-native-reanimated@3.7.2

  applied to

    react-native-reanimated@3.8.1
  
  At path
  
    node_modules/react-native-reanimated

  This warning is just to give you a heads-up. There is a small chance of
  breakage even though the patch was applied successfully. Make sure the package
  still behaves like you expect (you wrote tests, right?) and then run

    patch-package react-native-reanimated

  to update the version in the patch file name and make this warning go away.

[Ahmed-Abdella]

Okay thanks, in the meantime I'll need to switch proposals as this issue is a major blocker for us internally. We can sort out bounties later.

@Julesssss Sure thing. I just couldn't test it on iOS because there was a bug causing an iOS build failure.

[Julesssss]

Hey @Pujan92, @QichenZhu's PR is ready for testing now/ Let us know if you aren't available. thanks

[Pujan92]

Yes @Julesssss , looking into it and testing

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.7-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Make Slider Transformation Function Callback a worklet #45314
• Make ImageCropView animated style function a worklet #45400

If no regressions arise, payment will be issued on 2024-07-24. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 does not require payment (Contractor)
• @applausebot requires payment (Needs manual offer from BZ)
• @QichenZhu requires payment automatic offer (Contributor)
• @Ahmed-Abdella requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
• [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Pujan92] Determine if we should create a regression test for this bug.
• [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@yuwenmemon, @Pujan92, @applausebot, @muttmuure, @QichenZhu, @Ahmed-Abdella Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

@Pujan92 - $250 C+
@QichenZhu - $250 C
@Ahmed-Abdella - $250 C

[muttmuure]

@Pujan92 can you clarify if we need a regression test?

[Pujan92]

Regression Test Steps

1. Open profile page
2. Tap profile picture and select "upload photo"
3. Select any photo from gallary
4. Verify that the app doesn't crash

[JmillsExpensify]

$250 approved for @Pujan92

[melvin-bot]

@yuwenmemon, @Pujan92, @applausebot, @muttmuure, @QichenZhu, @Ahmed-Abdella Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@yuwenmemon, @Pujan92, @applausebot, @muttmuure, @QichenZhu, @Ahmed-Abdella Still overdue 6 days?! Let's take care of this!

[muttmuure]

Everyone is paid and regression test requested