Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-08-09] LHN - Long pressing chat does not show "Copy Onx Data" on all platforms #45521

Closed
2 of 6 tasks
m-natarajan opened this issue Jul 16, 2024 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@m-natarajan
Copy link

m-natarajan commented Jul 16, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Found when validating ##45079
Version Number: 9.0.7-4
Reproducible in staging?: y
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

  1. Access New Expensify app
  2. Sign into a valid account (Beta enabled)
  3. Long press on LHN

Expected Result:

User expects to see the option "Copy Onx Data" in popup menu

Actual Result:

User can not see this option on iOS and Android app

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6544288_1721154095539!Missing_ONYX_Data_in_popup_

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @trjExpensify
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. DeployBlocker Indicates it should block deploying the API labels Jul 16, 2024
Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jul 16, 2024

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jul 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@trjExpensify
Copy link
Contributor

From the PR, this is behind a beta and dev/staging only, so I don't think it's a Web blocker, or even really a App blocker.

Adds a new field for the context menu that allows to quickly copy onyx data of any report from the LHP for staging, dev and internal build environments.

CC: @puneetlath @sobitneupane @cdOut @war-in

@cdOut
Copy link
Contributor

cdOut commented Jul 16, 2024

This is not a blocker as it does not affect production and is only enabled for staging / dev and internal builds.

@rafecolton rafecolton removed the DeployBlocker Indicates it should block deploying the API label Jul 16, 2024
@cdOut
Copy link
Contributor

cdOut commented Jul 16, 2024

I'll look into it since I worked on the original PR implementing this feature, however as far as I remember it did work when I tested it on all platforms.

@m-natarajan did this happen on staging only? It seems like the conditional for checking the environment might have failed for some case there.

@thienlnam thienlnam added Weekly KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jul 16, 2024
@trjExpensify
Copy link
Contributor

@m-natarajan did this happen on staging only? It seems like the conditional for checking the environment might have failed for some case there.

@m-natarajan bump on this Q!

@cdOut
Copy link
Contributor

cdOut commented Jul 23, 2024

Second on the bump, I tried reproducing this one but I wasn't able to, were you testing this one on the emulators or using a physical device?

@m-natarajan
Copy link
Author

@trjExpensify @cdOut Yes on staging only, I am using physical device (iPhone Xs, App version 9.0.11-0) and able to reproduce.

@cdOut
Copy link
Contributor

cdOut commented Jul 23, 2024

Could you see whether it also happens for you when running on emulators?

@m-natarajan
Copy link
Author

@cdOut Applause QA never uses emulators.

@cdOut
Copy link
Contributor

cdOut commented Jul 23, 2024

Alright, I'll test it on a physical device and see if I can replicate it then. Thank you for clearing that up!

@cdOut
Copy link
Contributor

cdOut commented Jul 29, 2024

@m-natarajan has this been tested using an internal build or a staging build?

@trjExpensify
Copy link
Contributor

From the screenie in the OP, it's a staging build:

image

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 30, 2024
@melvin-bot melvin-bot bot changed the title LHN - Long pressing chat does not show "Copy Onx Data" on all platforms [HOLD for payment 2024-08-09] LHN - Long pressing chat does not show "Copy Onx Data" on all platforms Aug 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 2, 2024
Copy link

melvin-bot bot commented Aug 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Aug 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.15-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-09. 🎊

For reference, here are some details about the assignees on this issue:

  • @cdOut does not require payment (Contractor)

Copy link

melvin-bot bot commented Aug 2, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@bondydaa] The PR that introduced the bug has been identified. Link to the PR:
  • [@bondydaa] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@bondydaa] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@cdOut] Determine if we should create a regression test for this bug.
  • [@cdOut] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 8, 2024
@trjExpensify
Copy link
Contributor

@sobitneupane needs paying here for the C+ review.

Payment summary as follows:

  • $250 for the C+ review

Go ahead and request!

@garrettmknight
Copy link
Contributor

$250 approved for @sobitneupane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Development

No branches or pull requests

8 participants