"free trial ended" is missing from the report after running the given commands

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #44483
Version Number: 9.0.7-4
Reproducible in staging?: y
Reproducible in production?: unable to run the scripts
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/

2. Log in with a new Gmail account

3. Open Chrome console

4. Paste and run "Onyx.log("session")"

5. From the LHN, open Expensify if "accountID" in the console ends with an odd number. Open Concierge if it ends with an even number

6. Run all three of the attached codes from [Free trial] Implement and show Trial Ended banner, Expensify DM GBR and custom Expensify DM chat item in the App after Free Trial ends #44483
   QA step 4 in Chrome console

7. Refresh the page

Expected Result:

"free trial ended" message and "Add payment card" button should be available.

Actual Result:

"free trial ended" message and "Add payment card" button are missing from the report after running the given commands.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bandicam.2024-07-16.21-23-30-201.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @aldo-expensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[chiragsalian]

Not a blocker, its a new feature that we'll test shortly. Removing blocker label and closing issue.

[aldo-expensify]

Thanks @chiragsalian

[lanitochka17]

Issue is still reproducible

TC https://expensify.testrail.io/index.php?/tests/view/4893792

Free_trail_end.mp4

[jliexpensify]

@chiragsalian does this need to be re-opened?

[chiragsalian]

Nope, it doesn't need to be reopened. Looking at the video and issue again there are few things wrong.
Testing to receiving a free trial end message is a bit more complicated and not something easy for QA to test.
Just setting the onyx lastDayFreeTrial won't suffice.

The steps would be more like,

1. Ask ring1 to run a custom query to expire this NVP for the user in the database.
2. Find the bedrock job SendFreeTrialEndMessage for the user and retry it to run now. This job once run will send the message to the user.

Is this part of the scripts? Can someone share it with me so i can go over it and correct it as necessary.

[jliexpensify]

Sorry @chiragsalian I have no idea about any of this...I got assigned as Bug 0. I can assign Ring 1 if you like?

[chiragsalian]

Reassignment is not needed, i can help out here. Sorry i just noticed this is marked as hourly. It doesn't need to be. Demoting to weekly.

[chiragsalian]

For now lets wait for @lanitochka17 to reply to my post here and then we'll take it from there.

I feel like nothing needs be actioned here and we can just close this out since we've already tested it internally. But lets wait to confirm what QA says.

[jliexpensify]

Bump @lanitochka17 !

[jliexpensify]

@chiragsalian can we close this one?

[chiragsalian]

Yup lets close this out. @lanitochka17, if there is anything pending from our end or you have additional questions for us then feel free to reopen this issue.