-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pivotal ID # 176052254: JSON Submission Attributes Validation #310
Merged
jhoanmanuelms
merged 1 commit into
master
from
bugfix/pivotal-176052254-validate-empty-attributes-json
Dec 10, 2020
Merged
Pivotal ID # 176052254: JSON Submission Attributes Validation #310
jhoanmanuelms
merged 1 commit into
master
from
bugfix/pivotal-176052254-validate-empty-attributes-json
Dec 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Validate attribute values in JSON deserialization - Fix typo
Juan-EBI
approved these changes
Dec 10, 2020
jhoanmanuelms
deleted the
bugfix/pivotal-176052254-validate-empty-attributes-json
branch
December 10, 2020 10:23
jhoanmanuelms
added a commit
that referenced
this pull request
Dec 10, 2020
jhoanmanuelms
added a commit
that referenced
this pull request
Dec 10, 2020
Features: * Pivotal ID # 174054535: Disable superUser in request * Pivotal ID # 174076301: Update pmc api (#248) * Pivotal ID # 172817960: Resubmit Notfication (#255) * Pivotal ID # 169837866: Async File Processing (#256) * Pivotal ID # 172671360: Warn Users About Upcoming Releases (#268) * Pivotal ID # 173783625: Partial Updates Timestamp (#269) * Pivotal ID # 174922363: Add support for previous submission files source * Pivotal ID # 173908844: Add ext file fields attributes (#260) * Pivotal ID # 173817309: FIRE Client (#272) * Pivotal ID # 174746920: Include status fetching submissions (#275) * Pivotal ID # 171026062: Submission files MD5 Generation (#274) * Pivotal ID # 175266840: Manual Set AccNo Sequence (#287) * Pivotal ID # 175101522: File Path Field (#294) * Pivotal:ID # 175839554 : include user tag as part of extended submission tags (#296) * Pivotal ID # 175825508: Store submission request - async processing Bug Fixes: * Pivotal ID # 173457302: RelPath Calculation (#244) * Pivotal ID # 173750220: Author TSV Serialization (#245) * pivotal ID # 174127719: Transaction lock (#250) * Pivotal ID # 171230259: Draft creation time outs for big submissions (#251) * Pivotal ID # 174275642: Submission loading strategy (#254) * Pivotal ID # 174316468: Project Refresh AccNo Template Validation (#257) * Pivotal ID # 173919045: Restrict Execute Permissions On HTTP Uploaded Files (#265) * Pivotal ID # 174621725: Wrong Notifications UI URL (#266) * Pivotal ID # 174697743: Delete draft missing transaction * Pivotal ID # 174801815: Permissions For Deleted Submissions (#270) * Pivotal ID # 171026062: FTP Hard Links (#276) * Pivotal ID # 175357899: Re-submit a submission with rooPath (#279) * Pivotal ID # 175359447: Async Concurrent Processing Submission (#281) * Pivotal ID # 175780531: Ext Submission Submitter Validation (#300) * Pivotal ID # 175632448: Regular User Resubmission (#306) * Pivotal ID # 176052254: JSON Submission Attributes Validation (#310) * Pivotal ID # 176052264: Inner Folder Mapping (#311) Chore Tasks: * Pivotal ID # 174275207: Test Using The Persistence Layer (#262) * Pivotal ID # 174947046: ExtSubmission list api (#273) * Pivotal ID # 174274579: User eager groups (#280) * Pivotal ID # 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes (#283) * Pivotal ID # 175163839: Submission Operations Refactor (#297) * Pivotal ID # 175926073: Simplify accNoService (#298) * Pivotal ID # 175163839: Stats Refactor (#299)
jhoanmanuelms
added a commit
that referenced
this pull request
Dec 18, 2020
jhoanmanuelms
added a commit
that referenced
this pull request
Dec 18, 2020
jhoanmanuelms
added a commit
that referenced
this pull request
Mar 20, 2021
Feature * Pivotal ID # 176052254: JSON Submission Attributes Validation (#310) * Pivotal #ID:175163839: Submission Query Operations In Mongo (#319) * Pivotal-176168841: Allow to check inactive user registration (#315) * Pivotal ID # 176522202: Ext Submission serialization (#322) * Pivotal ID # 172671360: Warn users about upcoming public release (#324) * Pivotal #ID 176479707: Mongo implement draft funtionality (#327) * Pivotal #ID 176479720: Mongo Metadata Query (#328) * Pivotal ID # 175163839: Mongo Submission Stats (#331) * Pivotal ID # 176886357: Async Submission Request (#334) * Pivotal ID # 176977556: Delete Submissions In Mongo (#341) * Pivotal ID #176679139: Ext Submission File List Refactor (#344) * Pivotal ID # 177042374: Delete Draft After Submission (#349) * Pivotal ID# 174948695: PTSubmit Delete Operation (#351) * Pivotal #ID 177076728: Use PMC new streaming API (#346) * Pivotal ID # 177267343: Validate EU-ToxRisk Submissions (#352) Bugfix * Pivotal ID # 176052264: Inner Folder Mapping (#311) * Pivotal ID # 172671360: Ignore Empty Value Attributes (#314) * Pivotal ID # 176377632: File list extension is missing in BIA studies (#321) * Pivotal #ID 174642598: TSV Double Quotes (#350) * Pivotal ID # 176501169: FTP Folders Missing (#335) Chore * Pivotal ID # 176377544: Add refresh users directory structure api endpoint (#320) * Pivotal #ID 176479473: Migrate biostudies test to TestContainers (#323) * Pivotal ID # 176779952: Mongo iTests CI (#332) * Pivotal #Id 176838189: Rename PMC mongo collections (#333) * Pivotal #ID: 177040448: Store request as plain json (#336) * Pivotal ID #175894089: Check if queues in RabbitMQ are persistent (#339) * Pivotal ID #177074116 : model table section properly (#338) * Pivotal ID # 176886824: Improve API Docs (#337) * Pivotal #ID 177193125: Improve collection template validation (#345) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
jhoanmanuelms
added a commit
that referenced
this pull request
Mar 21, 2021
Feature * Pivotal ID # 176052254: JSON Submission Attributes Validation (#310) * Pivotal #ID:175163839: Submission Query Operations In Mongo (#319) * Pivotal-176168841: Allow to check inactive user registration (#315) * Pivotal ID # 176522202: Ext Submission serialization (#322) * Pivotal ID # 172671360: Warn users about upcoming public release (#324) * Pivotal #ID 176479707: Mongo implement draft funtionality (#327) * Pivotal #ID 176479720: Mongo Metadata Query (#328) * Pivotal ID # 175163839: Mongo Submission Stats (#331) * Pivotal ID # 176886357: Async Submission Request (#334) * Pivotal ID # 176977556: Delete Submissions In Mongo (#341) * Pivotal ID #176679139: Ext Submission File List Refactor (#344) * Pivotal ID # 177042374: Delete Draft After Submission (#349) * Pivotal ID# 174948695: PTSubmit Delete Operation (#351) * Pivotal #ID 177076728: Use PMC new streaming API (#346) * Pivotal ID # 177267343: Validate EU-ToxRisk Submissions (#352) Bugfix * Pivotal ID # 176052264: Inner Folder Mapping (#311) * Pivotal ID # 172671360: Ignore Empty Value Attributes (#314) * Pivotal ID # 176377632: File list extension is missing in BIA studies (#321) * Pivotal #ID 174642598: TSV Double Quotes (#350) * Pivotal ID # 176501169: FTP Folders Missing (#335) Chore * Pivotal ID # 176377544: Add refresh users directory structure api endpoint (#320) * Pivotal #ID 176479473: Migrate biostudies test to TestContainers (#323) * Pivotal ID # 176779952: Mongo iTests CI (#332) * Pivotal #Id 176838189: Rename PMC mongo collections (#333) * Pivotal #ID: 177040448: Store request as plain json (#336) * Pivotal ID #175894089: Check if queues in RabbitMQ are persistent (#339) * Pivotal ID #177074116 : model table section properly (#338) * Pivotal ID # 176886824: Improve API Docs (#337) * Pivotal #ID 177193125: Improve collection template validation (#345) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176052254