Pivotal ID # 172671360: Warn users about upcoming public release

[jhoanmanuelms]

https://www.pivotaltracker.com/story/show/172671360

• Log error instead of failing when getting extended submissions
• Fix notification messages

[Juan-EBI]

I think this logic should in the service.

    @Transactional(readOnly = true)
    override fun getExtendedSubmissions(filter: SubmissionFilter, offset: Long, limit: Int): Page<Result<ExtSubmission>> {
        val filterSpecs = SubmissionFilterSpecification(filter)
        val pageable = OffsetPageRequest(offset, limit, Sort.by(defaultOrder))

        return submissionRepository
            .findAll(filterSpecs.specification, pageable, EntityGraphs.named(SIMPLE_GRAPH))
            .map { runCatching { getExtByAccNoAndVersion(it.accNo, it.version) } }
    }

and in the service.

    fun getExtendedSubmissions(request: ExtPageRequest): Page<ExtSubmission> {
        val filter = SubmissionFilter(
            rTimeFrom = request.fromRTime,
            rTimeTo = request.toRTime,
            released = request.released
        )
        return submissionRepository
            .getExtendedSubmissions(filter, request.offset, request.limit)
            .onEach { it.onFailure { logger.error .... } }
            .map { it.getOrNull() }
            ....
    }

I would also add a unit test or many check that page is calculated correctly.

[Juan-EBI]

LGTM