Pivotal #ID 176479707: Mongo implement draft funtionality #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
Jan 27, 2021
|
|
||
| @TestInstance(TestInstance.Lifecycle.PER_CLASS) | ||
| @ExtendWith(MockKExtension::class) | ||
| class SubmissionDraftServiceTest( |
There was a problem hiding this comment.
It should be named SubmissionDraftSqlServiceTest
| import org.springframework.transaction.annotation.Transactional | ||
| import java.time.Instant | ||
|
|
||
| open class SubmissionSqlDraftService( |
There was a problem hiding this comment.
I'd suggest the name be SubmissionDraftSqlService since SubmissionDraft is the object in question and adding the "Sql" in the middle kind of breaks its meaning
| } | ||
|
|
||
| @Test | ||
| fun `get submission when does not exists`() { |
There was a problem hiding this comment.
This name is kind of misleading. Does it mean getting the draft when the submission doesn't exist or is it to generate the draft when the submission exists but the draft doesn't?
It's not clear to me what you're trying to test here.
| private val someFilter: PaginationFilter = PaginationFilter() | ||
|
|
||
| @Test | ||
| fun `get submission when exists`() { |
There was a problem hiding this comment.
Is this to get the draft when the submission exists? I think we should be as specific as possible with the name scenario since submission and draft are two different things
Juan-EBI
deleted the
feature/pivotal-176479707-Mongo-implement-draft-funtionality
branch
Juan-EBI
restored the
feature/pivotal-176479707-Mongo-implement-draft-funtionality
branch
Juan-EBI
deleted the
feature/pivotal-176479707-Mongo-implement-draft-funtionality
branch
jhoanmanuelms
added a commit
that referenced
this pull request
Mar 20, 2021
Feature * Pivotal ID # 176052254: JSON Submission Attributes Validation (#310) * Pivotal #ID:175163839: Submission Query Operations In Mongo (#319) * Pivotal-176168841: Allow to check inactive user registration (#315) * Pivotal ID # 176522202: Ext Submission serialization (#322) * Pivotal ID # 172671360: Warn users about upcoming public release (#324) * Pivotal #ID 176479707: Mongo implement draft funtionality (#327) * Pivotal #ID 176479720: Mongo Metadata Query (#328) * Pivotal ID # 175163839: Mongo Submission Stats (#331) * Pivotal ID # 176886357: Async Submission Request (#334) * Pivotal ID # 176977556: Delete Submissions In Mongo (#341) * Pivotal ID #176679139: Ext Submission File List Refactor (#344) * Pivotal ID # 177042374: Delete Draft After Submission (#349) * Pivotal ID# 174948695: PTSubmit Delete Operation (#351) * Pivotal #ID 177076728: Use PMC new streaming API (#346) * Pivotal ID # 177267343: Validate EU-ToxRisk Submissions (#352) Bugfix * Pivotal ID # 176052264: Inner Folder Mapping (#311) * Pivotal ID # 172671360: Ignore Empty Value Attributes (#314) * Pivotal ID # 176377632: File list extension is missing in BIA studies (#321) * Pivotal #ID 174642598: TSV Double Quotes (#350) * Pivotal ID # 176501169: FTP Folders Missing (#335) Chore * Pivotal ID # 176377544: Add refresh users directory structure api endpoint (#320) * Pivotal #ID 176479473: Migrate biostudies test to TestContainers (#323) * Pivotal ID # 176779952: Mongo iTests CI (#332) * Pivotal #Id 176838189: Rename PMC mongo collections (#333) * Pivotal #ID: 177040448: Store request as plain json (#336) * Pivotal ID #175894089: Check if queues in RabbitMQ are persistent (#339) * Pivotal ID #177074116 : model table section properly (#338) * Pivotal ID # 176886824: Improve API Docs (#337) * Pivotal #ID 177193125: Improve collection template validation (#345) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
jhoanmanuelms
added a commit
that referenced
this pull request
Mar 21, 2021
Feature * Pivotal ID # 176052254: JSON Submission Attributes Validation (#310) * Pivotal #ID:175163839: Submission Query Operations In Mongo (#319) * Pivotal-176168841: Allow to check inactive user registration (#315) * Pivotal ID # 176522202: Ext Submission serialization (#322) * Pivotal ID # 172671360: Warn users about upcoming public release (#324) * Pivotal #ID 176479707: Mongo implement draft funtionality (#327) * Pivotal #ID 176479720: Mongo Metadata Query (#328) * Pivotal ID # 175163839: Mongo Submission Stats (#331) * Pivotal ID # 176886357: Async Submission Request (#334) * Pivotal ID # 176977556: Delete Submissions In Mongo (#341) * Pivotal ID #176679139: Ext Submission File List Refactor (#344) * Pivotal ID # 177042374: Delete Draft After Submission (#349) * Pivotal ID# 174948695: PTSubmit Delete Operation (#351) * Pivotal #ID 177076728: Use PMC new streaming API (#346) * Pivotal ID # 177267343: Validate EU-ToxRisk Submissions (#352) Bugfix * Pivotal ID # 176052264: Inner Folder Mapping (#311) * Pivotal ID # 172671360: Ignore Empty Value Attributes (#314) * Pivotal ID # 176377632: File list extension is missing in BIA studies (#321) * Pivotal #ID 174642598: TSV Double Quotes (#350) * Pivotal ID # 176501169: FTP Folders Missing (#335) Chore * Pivotal ID # 176377544: Add refresh users directory structure api endpoint (#320) * Pivotal #ID 176479473: Migrate biostudies test to TestContainers (#323) * Pivotal ID # 176779952: Mongo iTests CI (#332) * Pivotal #Id 176838189: Rename PMC mongo collections (#333) * Pivotal #ID: 177040448: Store request as plain json (#336) * Pivotal ID #175894089: Check if queues in RabbitMQ are persistent (#339) * Pivotal ID #177074116 : model table section properly (#338) * Pivotal ID # 176886824: Improve API Docs (#337) * Pivotal #ID 177193125: Improve collection template validation (#345) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176479707