Pivotal #ID 176479720: Mongo Metadata Query #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhoanmanuelms
approved these changes
Jan 27, 2021
|
|
||
| class SubmissionMongoMetaQueryService : SubmissionMetaQueryService { | ||
| override fun getBasicProject(accNo: String): BasicProject { |
There was a problem hiding this comment.
Perhaps we should consider changing the notation from "projects" to "collections" which is the new term from the business point of view
There was a problem hiding this comment.
let's discuss and address individually this looks like a refactor rather than a clean improvement or something that is part of mongo support.
| } | ||
| } | ||
|
|
||
| fun DocSubmission.asBasicSubmission(): BasicSubmission { |
There was a problem hiding this comment.
I think these methods should be part of a DocSubmissionExt class instead of being here
| companion object { | ||
|
|
||
| private fun DocProcessingStatus.toProcessingStatus(): ProcessingStatus { | ||
| return when (this) { |
There was a problem hiding this comment.
These could all be one-liners
| } | ||
|
|
||
| @Test | ||
| fun getAccessTags() { |
There was a problem hiding this comment.
Apparently, you missed this one
There was a problem hiding this comment.
yes including this last one in another PR, deleting test method now
| assertThat(submissionMongoRepository.existsByAccNo("accNo5")).isFalse() | ||
| } | ||
|
|
||
| private fun testDocSubmission( |
There was a problem hiding this comment.
It might be a good idea to have this in a factory so it can be reused in other tests like
| companion object { | ||
|
|
||
| @Container | ||
| val mongoContainer: MongoDBContainer = MongoDBContainer(DockerImageName.parse("mongo:4.0.10")) |
There was a problem hiding this comment.
- Is this the mongo version we should be using and is it the same as the version provided by IT?
- Maybe we should have this in some sort of constant. Not sure if the versions declared here can be referenced in the code 🤔
…services into feature/pivotal-176479720-Mongo-Metadata-Query
jhoanmanuelms
added a commit
that referenced
this pull request
Mar 20, 2021
Feature * Pivotal ID # 176052254: JSON Submission Attributes Validation (#310) * Pivotal #ID:175163839: Submission Query Operations In Mongo (#319) * Pivotal-176168841: Allow to check inactive user registration (#315) * Pivotal ID # 176522202: Ext Submission serialization (#322) * Pivotal ID # 172671360: Warn users about upcoming public release (#324) * Pivotal #ID 176479707: Mongo implement draft funtionality (#327) * Pivotal #ID 176479720: Mongo Metadata Query (#328) * Pivotal ID # 175163839: Mongo Submission Stats (#331) * Pivotal ID # 176886357: Async Submission Request (#334) * Pivotal ID # 176977556: Delete Submissions In Mongo (#341) * Pivotal ID #176679139: Ext Submission File List Refactor (#344) * Pivotal ID # 177042374: Delete Draft After Submission (#349) * Pivotal ID# 174948695: PTSubmit Delete Operation (#351) * Pivotal #ID 177076728: Use PMC new streaming API (#346) * Pivotal ID # 177267343: Validate EU-ToxRisk Submissions (#352) Bugfix * Pivotal ID # 176052264: Inner Folder Mapping (#311) * Pivotal ID # 172671360: Ignore Empty Value Attributes (#314) * Pivotal ID # 176377632: File list extension is missing in BIA studies (#321) * Pivotal #ID 174642598: TSV Double Quotes (#350) * Pivotal ID # 176501169: FTP Folders Missing (#335) Chore * Pivotal ID # 176377544: Add refresh users directory structure api endpoint (#320) * Pivotal #ID 176479473: Migrate biostudies test to TestContainers (#323) * Pivotal ID # 176779952: Mongo iTests CI (#332) * Pivotal #Id 176838189: Rename PMC mongo collections (#333) * Pivotal #ID: 177040448: Store request as plain json (#336) * Pivotal ID #175894089: Check if queues in RabbitMQ are persistent (#339) * Pivotal ID #177074116 : model table section properly (#338) * Pivotal ID # 176886824: Improve API Docs (#337) * Pivotal #ID 177193125: Improve collection template validation (#345) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
jhoanmanuelms
added a commit
that referenced
this pull request
Mar 21, 2021
Feature * Pivotal ID # 176052254: JSON Submission Attributes Validation (#310) * Pivotal #ID:175163839: Submission Query Operations In Mongo (#319) * Pivotal-176168841: Allow to check inactive user registration (#315) * Pivotal ID # 176522202: Ext Submission serialization (#322) * Pivotal ID # 172671360: Warn users about upcoming public release (#324) * Pivotal #ID 176479707: Mongo implement draft funtionality (#327) * Pivotal #ID 176479720: Mongo Metadata Query (#328) * Pivotal ID # 175163839: Mongo Submission Stats (#331) * Pivotal ID # 176886357: Async Submission Request (#334) * Pivotal ID # 176977556: Delete Submissions In Mongo (#341) * Pivotal ID #176679139: Ext Submission File List Refactor (#344) * Pivotal ID # 177042374: Delete Draft After Submission (#349) * Pivotal ID# 174948695: PTSubmit Delete Operation (#351) * Pivotal #ID 177076728: Use PMC new streaming API (#346) * Pivotal ID # 177267343: Validate EU-ToxRisk Submissions (#352) Bugfix * Pivotal ID # 176052264: Inner Folder Mapping (#311) * Pivotal ID # 172671360: Ignore Empty Value Attributes (#314) * Pivotal ID # 176377632: File list extension is missing in BIA studies (#321) * Pivotal #ID 174642598: TSV Double Quotes (#350) * Pivotal ID # 176501169: FTP Folders Missing (#335) Chore * Pivotal ID # 176377544: Add refresh users directory structure api endpoint (#320) * Pivotal #ID 176479473: Migrate biostudies test to TestContainers (#323) * Pivotal ID # 176779952: Mongo iTests CI (#332) * Pivotal #Id 176838189: Rename PMC mongo collections (#333) * Pivotal #ID: 177040448: Store request as plain json (#336) * Pivotal ID #175894089: Check if queues in RabbitMQ are persistent (#339) * Pivotal ID #177074116 : model table section properly (#338) * Pivotal ID # 176886824: Improve API Docs (#337) * Pivotal #ID 177193125: Improve collection template validation (#345) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/story/show/176479720