Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pivotal ID #171026062: Submission files MD5 Generation #274

Merged
merged 3 commits into from
Oct 12, 2020
Merged

Pivotal ID #171026062: Submission files MD5 Generation #274

merged 3 commits into from
Oct 12, 2020

Conversation

jhoanmanuelms
Copy link
Contributor

https://www.pivotaltracker.com/story/show/171026062

  • Create a method for MD5 generation
  • Verify MD5 to decide whether or not a file should be copied

@jhoanmanuelms
Pivotal ID #171026062: Submission files MD5 Generation
5a39d17 
- Create a method for MD5 generation
- Verify MD5 to decide whether or not a file should be copied
@jhoanmanuelms jhoanmanuelms self-assigned this Oct 5, 2020
@jhoanmanuelms jhoanmanuelms requested a review from Juan-EBI October 5, 2020 12:21
Juan-EBI
Juan-EBI reviewed Oct 5, 2020
View reviewed changes
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear for me here changes, I think expectation here is to calculate and store files md5 in db rather than take decision if copy or move files.

.../persistence/src/main/kotlin/ac/uk/ebi/biostd/persistence/service/filesystem/FilesService.kt Show resolved Hide resolved
@jhoanmanuelms
Pivotal ID #171026062: Submission files MD5 Generation
5525f1d 
- Include MD5 and size in the extended model
- Add testing
Juan-EBI
Juan-EBI approved these changes Oct 9, 2020
View reviewed changes
Copy link
Contributor

@Juan-EBI Juan-EBI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhoanmanuelms jhoanmanuelms merged commit 94510a8 into master Oct 12, 2020
@jhoanmanuelms jhoanmanuelms deleted the feature/pivotal-171026062-md5-validation branch October 12, 2020 11:33
jhoanmanuelms added a commit that referenced this pull request Dec 10, 2020
@jhoanmanuelms @Juan-EBI
Promote To PROD (#308)
ac70156 
* Pivotal ID # 173457302: RelPath Calculation (#244)
* Pivotal ID # 173750220: Author TSV Serialization (#245)
* Pivotal ID # 172817960: Resubmit Notification (#243)
* Pivotal ID # 174054535: Disable superUser in request
* Pivotal #Id: 174076301: Update pmc api  (#248)
* pivotal #Id 174127719: Transaction lock (#250)
* Pivotal ID # 171230259: Draft creation time outs for big submissions (#251)
* Pivotal ID # 172817960: Resubmit Notfication (#253)
* Pivotal #ID 174275642: Submission loading strategy (#254)
* Pivotal ID # 172817960: Resubmit Notfication (#255)
* Pivotal #ID: 173457302 : fixed relpath calculation (#246)
* Pivotal ID # 174316468: Project Refresh AccNo Template Validation (#257)
* Pivotal #ID: 169837866: Async File Processing (#256)
* Pivotal ID # 169837866: Async File Processing (#259)
* Pivotal ID # 169837866: Async File Processing (#261)
* Pivotal ID # 174275207: Test Using The Persistence Layer (#262)
* Pivotal ID # 174275207: Test Using The Persistence Layer
* Pivotal ID # 173919045: Restrict Execute Permissions On HTTP Uploaded Files (#265)
* Pivotal ID # 174621725: Wrong Notifications UI URL (#266)
* Pivotal-174697743: Delete draft missing transaction
* Pivotal ID # 174801815: Permissions For Deleted Submissions (#270)
* Pivotal ID # 174801815: Permissions For Deleted Submissions
* Pivotal ID # 174801815: Permissions For Deleted Submissions
* Pivotal ID # 172671360: Warn Users About Upcoming Releases (#268)
* Pivotal ID # 172671360: Warn Users About Upcoming Releases
* Pivotal ID # 173783625: Partial Updates Timestamp (#269)
* Pivotal #ID : 174922363: Add support for previous submission files source
* Pivotal #ID 173908844: Add ext file fields attributes (#260)
* Pivotal ID # 173817309: FIRE Client (#272)
* Pivotal #ID: 174746920: Include status fetching submissions (#275)
* Pivotal #ID 174947046: ExtSubmission list api (#273)
* Pivotal ID # 171026062: FTP Hard Links (#276)
* Pivotal ID #171026062: Submission files MD5 Generation (#274)
* Pivotal #Id: Re-submit a submission with rooPath (#279)
* Pivotal #Id: 174274579: User eager groups (#280)
* Pivotal ID # 172671360: Warn Users About Upcoming Public Release (#282)
* Pivotal ID # 175359447: Async Concurrent Processing Submission (#281)
* Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes (#283)
* Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes
* Pivotal ID # 175359447: Async Concurrent Processing Submission (#285)
* Pivotal ID # 175359447: Async Concurrent Processing Submission [HotFix] (#288)
* Pivotal ID: 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes  (#289)
* Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes
* Pivotal ID # 175266840: Manual Set AccNo Sequence (#287)
* Pivotal ID # 175266840: Manual Set AccNo Sequence
* Pivotal ID: 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes (#290)
* Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes
* Pivotal ID # 175266840: Manual Set AccNo Sequence [HotFix] (#291)
* Pivotal ID # 172671360: Warn Users About Upcoming Public Release  (#278)
* Pivotal ID # 172671360: Warn Users About Upcoming Public Release
* Pivotal ID # 175101522: File Path Field (#294)
* Pivotal: ID: 175839554 : include user tag as part of extended submission tags (#296)
* Pivotal #ID: 175825508: Store submission request - async processing
* Pivotal-175839554: Include user tag as part of extended submission tags
* Pivotal # 175163839: Submission Operations Refactor (#297)
* Pivotal # 175163839: Submission Operations Refactor
* Pivotal #Id: 175926073: Simplify accNoService (#298)
* Pivotal ID # 175163839: Stats Refactor (#299)
* Pivotal ID # 175780531: Ext Submission Submitter Validation (#300)
* Temp FTP Resource (#277)
* Pivotal ID # 172671360: Warn Users About Upcoming Public Release (#304)
* Pivotal ID # 175632448: Regular User Resubmission (#306)

Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
jhoanmanuelms added a commit that referenced this pull request Dec 10, 2020
@jhoanmanuelms
Promote to PROD (#313)
31cbec5 
Features:
* Pivotal ID # 174054535: Disable superUser in request
* Pivotal ID # 174076301: Update pmc api  (#248)
* Pivotal ID # 172817960: Resubmit Notfication (#255)
* Pivotal ID # 169837866: Async File Processing (#256)
* Pivotal ID # 172671360: Warn Users About Upcoming Releases (#268)
* Pivotal ID # 173783625: Partial Updates Timestamp (#269)
* Pivotal ID # 174922363: Add support for previous submission files source
* Pivotal ID # 173908844: Add ext file fields attributes (#260)
* Pivotal ID # 173817309: FIRE Client (#272)
* Pivotal ID # 174746920: Include status fetching submissions (#275)
* Pivotal ID # 171026062: Submission files MD5 Generation (#274)
* Pivotal ID # 175266840: Manual Set AccNo Sequence (#287)
* Pivotal ID # 175101522: File Path Field (#294)
* Pivotal:ID # 175839554 : include user tag as part of extended submission tags (#296)
* Pivotal ID # 175825508: Store submission request - async processing

Bug Fixes:
* Pivotal ID # 173457302: RelPath Calculation (#244)
* Pivotal ID # 173750220: Author TSV Serialization (#245)
* pivotal ID # 174127719: Transaction lock (#250)
* Pivotal ID # 171230259: Draft creation time outs for big submissions (#251)
* Pivotal ID # 174275642: Submission loading strategy (#254)
* Pivotal ID # 174316468: Project Refresh AccNo Template Validation (#257)
* Pivotal ID # 173919045: Restrict Execute Permissions On HTTP Uploaded Files (#265)
* Pivotal ID # 174621725: Wrong Notifications UI URL (#266)
* Pivotal ID # 174697743: Delete draft missing transaction
* Pivotal ID # 174801815: Permissions For Deleted Submissions (#270)
* Pivotal ID # 171026062: FTP Hard Links (#276)
* Pivotal ID # 175357899: Re-submit a submission with rooPath (#279)
* Pivotal ID # 175359447: Async Concurrent Processing Submission (#281)
* Pivotal ID # 175780531: Ext Submission Submitter Validation (#300)
* Pivotal ID # 175632448: Regular User Resubmission (#306)
* Pivotal ID # 176052254: JSON Submission Attributes Validation (#310)
* Pivotal ID # 176052264: Inner Folder Mapping (#311)

Chore Tasks:
* Pivotal ID # 174275207: Test Using The Persistence Layer (#262)
* Pivotal ID # 174947046: ExtSubmission list api (#273)
* Pivotal ID # 174274579: User eager groups (#280)
* Pivotal ID # 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes (#283)
* Pivotal ID # 175163839: Submission Operations Refactor (#297)
* Pivotal ID # 175926073: Simplify accNoService (#298)
* Pivotal ID # 175163839: Stats Refactor (#299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juan-EBI Juan-EBI Juan-EBI approved these changes

Assignees

@jhoanmanuelms jhoanmanuelms

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhoanmanuelms @Juan-EBI