Pivotal ID: 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…services into feature/pivotal-175632448-Extra-persistence-layer-interfaces-to-avoid-dependencies-on-SQL-classes
…services into feature/pivotal-175632448-Extra-persistence-layer-interfaces-to-avoid-dependencies-on-SQL-classes
jhoanmanuelms
approved these changes
Nov 14, 2020
| package ac.uk.ebi.biostd.persistence.common.service | ||
|
|
||
| @Suppress("TooManyFunctions") | ||
| interface PersistenceService { |
There was a problem hiding this comment.
Just 5 triggers too many functions??
| import ac.uk.ebi.biostd.persistence.common.service.SubmissionQueryService | ||
| import ebi.ac.uk.extended.mapping.to.toSimpleSubmission | ||
|
|
||
| fun SubmissionQueryService.getSimpleByAccNo(accNo: String) = getExtByAccNo(accNo).toSimpleSubmission() |
There was a problem hiding this comment.
Why is this an extension?
There was a problem hiding this comment.
This service comes from the persistence module so if we won't allow it in class we need to add the serialization module as a dependency on persistence. As that is not necessary at all. I Declared this an extension of main product (that already depends on the serialization model)
| import java.time.OffsetDateTime | ||
|
|
||
| interface SubmissionRequestService { | ||
| fun saveAndProcessSubmissionRequest(saveRequest: SaveSubmissionRequest): ExtSubmission |
There was a problem hiding this comment.
As discussed in my last PR this should be separated?
Juan-EBI
deleted the
feature/pivotal-175632448-Extra-persistence-layer-interfaces-to-avoid-dependencies-on-SQL-classes
branch
jhoanmanuelms
added a commit
that referenced
this pull request
Dec 10, 2020
* Pivotal ID # 173457302: RelPath Calculation (#244) * Pivotal ID # 173750220: Author TSV Serialization (#245) * Pivotal ID # 172817960: Resubmit Notification (#243) * Pivotal ID # 174054535: Disable superUser in request * Pivotal #Id: 174076301: Update pmc api (#248) * pivotal #Id 174127719: Transaction lock (#250) * Pivotal ID # 171230259: Draft creation time outs for big submissions (#251) * Pivotal ID # 172817960: Resubmit Notfication (#253) * Pivotal #ID 174275642: Submission loading strategy (#254) * Pivotal ID # 172817960: Resubmit Notfication (#255) * Pivotal #ID: 173457302 : fixed relpath calculation (#246) * Pivotal ID # 174316468: Project Refresh AccNo Template Validation (#257) * Pivotal #ID: 169837866: Async File Processing (#256) * Pivotal ID # 169837866: Async File Processing (#259) * Pivotal ID # 169837866: Async File Processing (#261) * Pivotal ID # 174275207: Test Using The Persistence Layer (#262) * Pivotal ID # 174275207: Test Using The Persistence Layer * Pivotal ID # 173919045: Restrict Execute Permissions On HTTP Uploaded Files (#265) * Pivotal ID # 174621725: Wrong Notifications UI URL (#266) * Pivotal-174697743: Delete draft missing transaction * Pivotal ID # 174801815: Permissions For Deleted Submissions (#270) * Pivotal ID # 174801815: Permissions For Deleted Submissions * Pivotal ID # 174801815: Permissions For Deleted Submissions * Pivotal ID # 172671360: Warn Users About Upcoming Releases (#268) * Pivotal ID # 172671360: Warn Users About Upcoming Releases * Pivotal ID # 173783625: Partial Updates Timestamp (#269) * Pivotal #ID : 174922363: Add support for previous submission files source * Pivotal #ID 173908844: Add ext file fields attributes (#260) * Pivotal ID # 173817309: FIRE Client (#272) * Pivotal #ID: 174746920: Include status fetching submissions (#275) * Pivotal #ID 174947046: ExtSubmission list api (#273) * Pivotal ID # 171026062: FTP Hard Links (#276) * Pivotal ID #171026062: Submission files MD5 Generation (#274) * Pivotal #Id: Re-submit a submission with rooPath (#279) * Pivotal #Id: 174274579: User eager groups (#280) * Pivotal ID # 172671360: Warn Users About Upcoming Public Release (#282) * Pivotal ID # 175359447: Async Concurrent Processing Submission (#281) * Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes (#283) * Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes * Pivotal ID # 175359447: Async Concurrent Processing Submission (#285) * Pivotal ID # 175359447: Async Concurrent Processing Submission [HotFix] (#288) * Pivotal ID: 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes (#289) * Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes * Pivotal ID # 175266840: Manual Set AccNo Sequence (#287) * Pivotal ID # 175266840: Manual Set AccNo Sequence * Pivotal ID: 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes (#290) * Pivotal #ID 175632448: Extra persistence layer interfaces to avoid dependencies on SQL classes * Pivotal ID # 175266840: Manual Set AccNo Sequence [HotFix] (#291) * Pivotal ID # 172671360: Warn Users About Upcoming Public Release (#278) * Pivotal ID # 172671360: Warn Users About Upcoming Public Release * Pivotal ID # 175101522: File Path Field (#294) * Pivotal: ID: 175839554 : include user tag as part of extended submission tags (#296) * Pivotal #ID: 175825508: Store submission request - async processing * Pivotal-175839554: Include user tag as part of extended submission tags * Pivotal # 175163839: Submission Operations Refactor (#297) * Pivotal # 175163839: Submission Operations Refactor * Pivotal #Id: 175926073: Simplify accNoService (#298) * Pivotal ID # 175163839: Stats Refactor (#299) * Pivotal ID # 175780531: Ext Submission Submitter Validation (#300) * Temp FTP Resource (#277) * Pivotal ID # 172671360: Warn Users About Upcoming Public Release (#304) * Pivotal ID # 175632448: Regular User Resubmission (#306) Co-authored-by: Juan <jcamilorada@ebi.ac.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.pivotaltracker.com/n/projects/1189310