[ADLA] - [HOTFIX] - Adding an InnerError property to JobInnerError.cs #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sql: Add support for VirtualNetworkRules
…ent, tests, recordings (Azure#3375) * Add server communication links and geo backup policies scenario tests and client * Add recordings * Update generate.cmd compositeSql.json reference * Remove vnet firewall rule files * Regen from swagger * Rename test, re-record * Added restore dropped database to DatabaseRestoreScenarioTests * Add delete communication link scenario test * Add stub TestLongTermRetentionCrud * Separate PITR and dropped db restore tests. * Some work on LTR CRUD test * Finish LTR test * Confirmed that these properties should be required. Will update swagger. * Regen with required properties * Regen from swagger to update LTR policy * Stub TestDatabaseGeoRecovery * GeoRecovery tests * Regen from swagger * Bump version to 1.7.0-preview. Note that virtual network support will be 1.6.0-preview. * Fixed GetGeoBackupPolicy build error * Record LTR test * Changed version to 1.6.0-preview
* Add Data Masking client, tests, recordings * Update threat detection recording * Update compositeSql.json to reflect commit used * Respond to comments, re-record * Remove unused variable
… testcases. (Azure#3404) * Dotnet client SDK - generated code and testcases, for StorSimple 8000 Series ARM APIs. * Adding nuget reference using import AzSdk.test.reference.props. Removing other not required namespaces. * Adding missing packageId desc. etc in test project .csproj * Fixing case in name of referred .csproj filename(of generated class library) * Moving sessionRecords folder to the right location. * Re-recording 3 of the failing testcases. * Need to have all datetime part of OdataQuery in UTC. Earlier it was in local-time, hence during travis build, URL created(local time of build server) was not found in session-recording.
* Regenerated SDK basing on specs updates * Added tests for VMSS Public IP; Updated versions * Updated packages versions; Re-recorded tests * Stripped redundant code
…e#3400) This allows them to be easily re-recorded later.
* Expose new fields for bgp and community object * Update api version * remove unneeded files * remove unneeded files * update version * add tests * add customized init * fix format * update tests
* Network version update and ApplicationGateway New features * modifed tests for 2017-06-01 version * bumped up the version in assemblyInfo * bumped up the network csproj file to 11.0.0-preview
Azure#3393) * use new endpoint to read SKUs during validation and updates for backup container uri * fix tests * minor update in api specs * use latest autoRest to generate the SDK * bump up version
* changes related to Eventhub New RP version 2017-04-01 * Version updated * generated.cmd changes * Code generated with lateset AutoRest * Version changes. * updated with new property swagger changes.
* swagger changes * added more subscription properites in creation * Code generatedwith new swagger of new RP version 2017-04-01 * Version updated and session records * Reset with upstream and swagger related changes for new RP version * Session records updated * Version updated.
…evel' (Azure#3432) * removing 'preview' tag from KeyVault SDK * removing the 'preview' tag from KeyVault SDK * Replacing the KeyVault attribute 'purgeDisabled' with a string, enumerated deletion recovery level (restoring lost commit) adding deletion recovery level to KV attributes updated tests and recordings * Replacing the KeyVault attribute 'purgeDisabled' with a string, enumerated deletion recovery level (restoring lost commit) adding deletion recovery level to KV attributes updated tests and recordings * removing duplicate project reference * removing reference to Json6 from the .net452 target of KV WebKey test project
…s are for CloudAppliance, CancelJob, SyncRemoteManagement (Azure#3434)
* update snapshot and compute version * update snapshot and compute version
Added private access services tests
…piVersion update network client api version for vmss
reverting private-dns sdk changes
…e#3740) * Adding state and migration flag from latest swagger and updating tests * Bumped version to 1.8.0-preview * Removed whitespace at start of line * Fixed merge conflict in Microsoft.Azure.Management.Sql.csproj
slightly more robust and flexible AutoRest version detection
Update Azure Batch SDK to 8.0
* GEO DR changes * Version updated * GeoDR tests * Latest swagger code * updated the Version and metadata file.
* Geo DR changes * Geo DR Tests * Latest swagger code * Removed the Length tests for subscription and authorizationrules as this is reverted. * updated PR description, version and metadata file. * updated PackageReleaseNotes
* Add BatchAI SDK and tests * fix test name issue * fix playback failure issue * try to fix error CS0246 in build * try to fix continuous-integration/travis-ci/pr failure * regenerate the SDK with updated swagger * addressed comments in PR * delete nodejs dir
…st spec change (Azure#3753) * Fixing folder structure, regenerating SDKs based on latest spec change * Removing more unnecessary csproj entries * Using generate.cmd command (changed to run locally since PR is not merged yet) to regenerate classes * Deleting stale file from previous generation
) * Generate .NET SDK for application insights * update assembly version * address code review feedback * address code review feedback * regenerate sdk for adding management api keys functions * remove local used LaunchSettings.json file * generate from the pulic swagger * increase version in csproj file
* Moving old files which are not used anymore to legacy directory * Separate build tools from branch. Moving forward build tools will be downloaded from a central location, this helps in propogating build changes to any branch dynamically. After this change build process on a new machine or fresh install will be a two step process. First download the build tools by executing msbuild build.proj and once it finishes, then execute whatever target you need to do e.g. msbuild build.proj /t:RunTests /p:Scope=SDKs\Compute. After downloading all build related assets will be downloaded under <root>\tools\SdkBuildTools. Moving bunch of legacy code to legacy directory. Removing build tasks out of this branch, currently being moved to legacy directory
Updating readme to document recent build changes that were done to extract build tools out of main branch.
* This is the first batch of scenario tests for the ADF V2 SDK. * Partially addresses Azure#3726; more tests need to be added
* This affects only ADLA Job
…-3-0-2-inner-error
ro-joowan
force-pushed
the
adl-hotfix-3-0-2-inner-error
branch
from
2ffd522 to
20ceebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger repo -- fork of Azure/current: git reset --hard 9556a7371292a1362ac0b3eb5fbfd2f06f3d5859: Azure/azure-rest-api-specs@9556a73
This is because this commit is right before Ben's update from version 3.0.1 to version 3.1.0-preview, as shown here: https://github.com/Azure/azure-rest-api-specs/commits/current?before=d8aba4a6092b536a0eec12ca66dbbcc26406136c+280
Code gen based on my Swagger fork: https://github.com/ro-joowan/azure-rest-api-specs/commits/hotfix-inner-error
SDK repo -- fork of Azure/psSdkJson6: git reset --hard 20ceebb
This is because this was the last commit for ADLA version 3.0.1 -- this hotfix version is 3.0.2
Commit-list view: https://github.com/Azure/azure-sdk-for-net/commits/psSdkJson6?after=2ffd522a97aa6f88749d30e22355b6aa928ea3e5+139
This change was approved before in a past PR: [BUG FIX] - Making JobInnerError object recursively defined #3666
Primary change is in here: src\SDKs\DataLake.Analytics\Management.DataLake.Analytics\Generated\Models\JobInnerError.cs
I submitted a separate PR for the changelog update: [ADLA] - Update changelog for version 3.0.2 #3792
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.