Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding few more testcases and corresponding session-records. Testcase… #3434

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

manaas-microsoft
Copy link
Contributor

@manaas-microsoft manaas-microsoft commented Jun 29, 2017

…s are for CloudAppliance, CancelJob, SyncRemoteManagement

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

…s are for CloudAppliance, CancelJob, SyncRemoteManagement
@msftclas
Copy link

@manaas-microsoft,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@manaas-microsoft
Copy link
Contributor Author

@shahabhijeet Hi, As discussed last Friday, this is the second and the last PR, containing few more testcases and corresponding session-recordings. In the generated dotnet code, I have fixed the project names at 2-3 places(wherever 'series' of StorSimple8000Series was in small letters).

@manaas-microsoft
Copy link
Contributor Author

@shahabhijeet Hi, Could you please merge this, as this is already approved by you? Also, once this is merged, how can I access this as nuget package? If there are some steps to make it available to nuget, could you please point me to the steps?

@shahabhijeet shahabhijeet merged commit b87576b into Azure:psSdkJson6 Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants