New RP version for EventHub #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahabhijeet
approved these changes
Jun 28, 2017
| @@ -9,5 +9,6 @@ | |||
| </PropertyGroup> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net452;netstandard1.4</TargetFrameworks> | |||
| <Version>2.0.0</Version> | |||
There was a problem hiding this comment.
@v-Ajnava let's stick with for now.
shahabhijeet
suggested changes
Jun 28, 2017
shahabhijeet
suggested changes
Jun 28, 2017
| @@ -8,7 +8,7 @@ | |||
| [assembly: AssemblyDescription("Provides developers with a library to create and manage all Azure Event Hubs resources.")] | |||
|
|
|||
| [assembly: AssemblyVersion("1.0.0.0")] | |||
There was a problem hiding this comment.
@v-Ajnava also AssemblyVersion needs to be bumped
shahabhijeet
approved these changes
Jun 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regenerating SDK for the new swagger for RP version 2017-04-01
New RP version swagger:
Azure/azure-rest-api-specs#1305
Azure/azure-rest-api-specs#1357
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.