KeyVault: replacing 'purgeDisabled' attribute with 'deletionRecoveryLevel' #3432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 26, 2017 16:56
…rated deletion recovery level (restoring lost commit) adding deletion recovery level to KV attributes updated tests and recordings
…rated deletion recovery level (restoring lost commit) adding deletion recovery level to KV attributes updated tests and recordings
pomortaz
approved these changes
Jun 28, 2017
| <PackageReference Include="Newtonsoft.Json"> | ||
| <Version>6.0.8</Version> | ||
| </PackageReference> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Yep, one was from the merge.. Fixed, thanks.
| : base(enabled, notBefore, expires, created, updated) | ||
| { | ||
| PurgeDisabled = purgeDisabled; | ||
| RecoveryLevel = recoveryLevel; |
There was a problem hiding this comment.
This is breaking change. We just published a stable nuget package. Please unlist that before publishing your changes.
shahabhijeet
suggested changes
Jun 29, 2017
| @@ -4,7 +4,7 @@ | |||
| <PackageId>Microsoft.Azure.KeyVault</PackageId> | |||
| <Description>Azure Key Vault enables users to store and use cryptographic keys within the Microsoft Azure environment. Azure Key Vault supports multiple key types and algorithms and enables the use of Hardware Security Modules (HSM) for high value customer keys. In addition, Azure Key Vault allows users to securely store secrets in a Key Vault; secrets are limited size octet objects and Azure Key Vault applies no specific semantics to these objects. A Key Vault may contain a mix of keys and secrets at the same time, and access control for the two types of object is independently controlled. Users, subject to appropriate authorization, may: 1) Manage cryptographic keys using Create, Import, Update, Delete and other operations 2) Manage secrets using Get, Set, Delete and other operations 3) Use cryptographic keys with Sign/Verify, WrapKey/UnwrapKey and Encrypt/Decrypt operations. Operations against Key Vaults are authenticated and authorized using Azure Active Directory. Key Vault now supports certificates, a complex type that makes use of existing key and secret infrastructure for certificate operations. KV certificates also support notification and auto-renewal as well as other management features.</Description> | |||
| <AssemblyTitle>Microsoft Azure key vault</AssemblyTitle> | |||
| <VersionPrefix>2.3.1</VersionPrefix> | |||
| <VersionPrefix>2.3.2</VersionPrefix> | |||
There was a problem hiding this comment.
@dragav if you have a breaking change, you should bump up your major version
There was a problem hiding this comment.
@shahabhijeet as discussed offline, this change would have been breaking if we kept the previous SDK version (v2.3.1). Since you unlisted that package, that makes this version (2.3.2) the first release of the SDK in this version range, and so we're not breaking anybody. All other consumers of the KV SDK in the 2.3* line would have used 'prerelease' builds, which implies the possibility of changes.
Thanks for your consideration.
shahabhijeet
approved these changes
Jun 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.