Sql: Add support for VirtualNetworkRules #3377
Conversation
|
Jenkins infra error, rerunning: http://azuresdkci.cloudapp.net/job/NetCore-SdkCI/480/ |
| string vnetfirewallRuleName = SqlManagementTestUtilities.GenerateName(testPrefix); | ||
| VirtualNetworkRule rule = new VirtualNetworkRule() | ||
| { | ||
| VirtualNetworkSubnetId = string.Format("/subscriptions/d513e2e9-97db-40f6-8d1a-ab3b340cc81a/resourceGroups/TestVnetSdk/providers/Microsoft.Network/virtualNetworks/vnetSdkTest/subnets/subnet1") |
There was a problem hiding this comment.
Isn't this just a hard-coded value that will make it more difficult to re-record the test?
There was a problem hiding this comment.
Yes this is bad long-term, the problem is that the network RP's API to create these virtual networks is not fully working in production so it's not possible to automate right now. We'll make an issue assigned to @dnayantara to update this asap.
There was a problem hiding this comment.
Yes! Unfortunately Networking team's .NET SDK code isnt public yet and they are also aiming for the July release. Once that is out, I plan to change these tests and re-record them using the Networking teams .Net sdk client code.
There was a problem hiding this comment.
Created issue #3388 and added TODO in code.
|
|
||
| VirtualNetworkRule toCreate = new VirtualNetworkRule() | ||
| { | ||
| VirtualNetworkSubnetId = string.Format("/subscriptions/d513e2e9-97db-40f6-8d1a-ab3b340cc81a/resourceGroups/TestVnetSdk/providers/Microsoft.Network/virtualNetworks/vnetSdkTest/subnets/subnet1") |
|
|
||
| VirtualNetworkRule toCreate = new VirtualNetworkRule() | ||
| { | ||
| VirtualNetworkSubnetId = string.Format("/subscriptions/d513e2e9-97db-40f6-8d1a-ab3b340cc81a/resourceGroups/TestVnetSdk/providers/Microsoft.Network/virtualNetworks/vnetSdkTest/subnets/subnet1") |
Description
Added VirtualNetworkRules feature including scenario tests.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.