Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rs conflict with fallback to patch replicaset refactor #3

Draft
wants to merge 84 commits into
base: fix-rs-conflict-with-fallback-to-patch
Choose a base branch
from

Conversation

zachaller
Copy link
Owner

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

zachaller and others added 30 commits June 7, 2024 11:53
* fix: fallback to patch on scale conflict

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

fix: switch to retry logic

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lint

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

retry experiments

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

remove TODO

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

remove accidental add

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

remove accidental add

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add retry to setting revision

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore(deps): bump slsa-framework/slsa-github-generator from 1.10.0 to 2.0.0 (argoproj#3537)

chore(deps): bump slsa-framework/slsa-github-generator

Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.10.0 to 2.0.0.
- [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases)
- [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
- [Commits](slsa-framework/slsa-github-generator@v1.10.0...v2.0.0)

---
updated-dependencies:
- dependency-name: slsa-framework/slsa-github-generator
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump sigstore/cosign-installer from 3.4.0 to 3.5.0 (argoproj#3522)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.4.0 to 3.5.0.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@e1523de...59acb62)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump golangci/golangci-lint-action from 4 to 5 (argoproj#3540)

Bumps [golangci/golangci-lint-action](https://github.com/golangci/golangci-lint-action) from 4 to 5.
- [Release notes](https://github.com/golangci/golangci-lint-action/releases)
- [Commits](golangci/golangci-lint-action@v4...v5)

---
updated-dependencies:
- dependency-name: golangci/golangci-lint-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

docs: provide recommendation for strategies (argoproj#3531)

* docs: provide recommendation for strategies

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: traffic manager clarifications

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: explain canary with/out traffic manager

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: add 3 columns on the comparison table

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

---------

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

feat(dashboard): change the color of the current rollout step (argoproj#3526)

I feel that having the current (running) step in a orange color is misleading,
as orange usually means warning.

This commit changes the color to the `$argo-running-color`.

Signed-off-by: Alejandro López Sánchez <alejandro.lopez@factorial.co>

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch from 1.37.0 to 1.38.0 (argoproj#3525)

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch

Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.37.0 to 1.38.0.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.38.0/CHANGELOG.md)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.37.0...service/s3/v1.38.0)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

perform all of set revision actions on retry

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

fix variable

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add retry counts to log

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add retry counts to logs

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

clean logs, always dump controller e2e logs

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lower timeout

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

bump timeout on e2e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

retry on rollout conflict

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

don't reque on rs changes

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

reque rs

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

bump qps for e2e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

fix gen-crd

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

switch to patch

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

switch to patch

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add log

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

move log lines

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

Trigger Build

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

fix one e2e test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lint

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

chore(deps): bump actions/setup-go from 5.0.0 to 5.0.1 (argoproj#3552)

Bumps [actions/setup-go](https://github.com/actions/setup-go) from 5.0.0 to 5.0.1.
- [Release notes](https://github.com/actions/setup-go/releases)
- [Commits](actions/setup-go@v5.0.0...v5.0.1)

---
updated-dependencies:
- dependency-name: actions/setup-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump codecov/codecov-action from 4.3.0 to 4.3.1 (argoproj#3550)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): bump google.golang.org/protobuf from 1.33.0 to 1.34.0 (argoproj#3548)

Bumps google.golang.org/protobuf from 1.33.0 to 1.34.0.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

refactor

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add test for updating rs revision

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add retry for ephemeral metadata

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

clear some fields

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

add logs

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

refactor into function

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

change log

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

switch rollout update to patch fallback

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

siwtch ephemeral metadata sync to shared function

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

siwtch merge type

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lint

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

don't update status

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

switch rollout update to not use patch

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

change log

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

switch to small patch

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

some cleanup

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

remove not found rollout removal

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

working setup

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

lint

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

fix test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

small cleanup

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* typo

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* cleanup commented out code

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* Trigger Build

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* only patch rollouts manged fields

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* lint

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix flaky test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix flaky test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* reduce patch size

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* get some logs

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* cleanup

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* improve tests

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* Trigger Build

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add env var to log diff

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove expirment rs patch

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* imporve logs

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* use correct variable

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* change env var

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix flaky e2e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix flaky e2e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix flaky e2e

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove not found rollouts

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* update replica count

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* lint

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* refactor cleanup

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* keep track of UpdatedReplicas on sync

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* some hpa tests and log changes

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove update to UpdatedReplicas

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add more test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* undo change

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add comment to flaky tests

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* cleanup Makefile

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* use labels

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* remove make file change

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add label to test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* review changes

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* change to TODO

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add extra logging for tests

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* Trigger Build

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add ignore to codecov

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* we always generate patch because we are comparing against emtpy obj

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…rgoproj#3621)

Bumps [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) from 1.27.0 to 1.27.2.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@v1.27.0...v1.27.2)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* add codecov token

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fail if we do not upload

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…#3627)

* fix: verify the weight of the alb at the end of the rollout when we auto set max weight

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add unit test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* refactor add unit test

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* Trigger Build

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* Trigger Build

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* block reconcile

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add tests

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* rename test and cleanup un-need logic check

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…y alb traffic management uses pingpong. (argoproj#3628)

* fix: when Rollout has pingpong and stable/canary service defined, GetStableAndCanaryServices returns based on isPingpongPreferred. Only when it is ALB controller, then isPringpongPreferred is true.

Signed-off-by: mayz985 <may_zhang@intuit.com>

* fix lint error

Signed-off-by: mayz985 <may_zhang@intuit.com>

* added e2e

Signed-off-by: mayz985 <may_zhang@intuit.com>

---------

Signed-off-by: mayz985 <may_zhang@intuit.com>
…ancingv2 from 1.31.1 to 1.31.3 (argoproj#3620)

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2

Bumps [github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2](https://github.com/aws/aws-sdk-go-v2) from 1.31.1 to 1.31.3.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.31.1...service/s3/v1.31.3)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/elasticloadbalancingv2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…goproj#3593 (argoproj#3603)

fix protocol missing in ambassador canary mapping creation

Signed-off-by: Joshua Mathew <umjoshua@gmail.com>
…#3631)

Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.20.0 to 0.21.0.
- [Commits](golang/oauth2@v0.20.0...v0.21.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roj#3624)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.3.0 to 5.4.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@2cdde99...ca052bb)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update changelog

* Update CHANGELOG.md

---------

Co-authored-by: zachaller <201390+zachaller@users.noreply.github.com>
Co-authored-by: Zach Aller <zachaller@users.noreply.github.com>
…j#3634)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.4.1 to 4.5.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v4.4.1...v4.5.0)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#3633)

Bumps google.golang.org/protobuf from 1.34.1 to 1.34.2.

---
updated-dependencies:
- dependency-name: google.golang.org/protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 1.27.18 (argoproj#3625)

chore(deps): bump github.com/aws/aws-sdk-go-v2/config

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.16 to 1.27.18.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.27.16...config/v1.27.18)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…m 1.38.0 to 1.38.6 (argoproj#3619)

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch

Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.38.0 to 1.38.6.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/s3/v1.38.0...service/kendra/v1.38.6)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Tommy Chen <tommy351@gmail.com>
…j#3640)

Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.8.0 to 1.8.1.
- [Release notes](https://github.com/spf13/cobra/releases)
- [Commits](spf13/cobra@v1.8.0...v1.8.1)

---
updated-dependencies:
- dependency-name: github.com/spf13/cobra
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
* fix: don't default datadog aggregator

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* codegen

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix: don't default datadog aggregator

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…m 1.38.6 to 1.38.7 (argoproj#3647)

chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch

Bumps [github.com/aws/aws-sdk-go-v2/service/cloudwatch](https://github.com/aws/aws-sdk-go-v2) from 1.38.6 to 1.38.7.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@service/kendra/v1.38.6...service/kendra/v1.38.7)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/service/cloudwatch
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roj#3644)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 5.4.0 to 6.0.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@ca052bb...c382f71)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
… 1.27.19 (argoproj#3646)

chore(deps): bump github.com/aws/aws-sdk-go-v2/config

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.18 to 1.27.19.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.27.18...config/v1.27.19)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
don't fail on failure

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…roj#3659)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.0.0 to 6.0.2.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@c382f71...f6010ea)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: xiaowu.zhu <xiaowu.zhu@daocloud.io>
Signed-off-by: root <root@daocloud.io>
…roj#3662)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.0.2 to 6.1.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@f6010ea...31159d4)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* update changelog

* Update CHANGELOG.md

* Update CHANGELOG.md

---------

Co-authored-by: zachaller <201390+zachaller@users.noreply.github.com>
Co-authored-by: Zach Aller <zachaller@users.noreply.github.com>
… 1.27.22 (argoproj#3680)

chore(deps): bump github.com/aws/aws-sdk-go-v2/config

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.19 to 1.27.22.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.27.19...config/v1.27.22)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roj#3676)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.1.0 to 6.2.0.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@31159d4...1556069)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…Fixes argoproj#3672 (argoproj#3675)

fix: add update verb to ClusterRole permissions for scaleDown

Signed-off-by: EnriqueTejeda <quique.tejeda.68@gmail.com>
…ysis Runs. Fixes argoproj#3669 (argoproj#3670)

* Ensure that BackgroundAnalysisRun does not run when rolling back within RollbackWindow

Signed-off-by: Alex Dunn <adunn@sofi.org>

* Fix linting

Signed-off-by: Alex Dunn <adunn@sofi.org>

---------

Signed-off-by: Alex Dunn <adunn@sofi.org>
cyrilico and others added 22 commits July 25, 2024 08:51
…ingresses. (argoproj#3671)

* refactor according to suggestions

Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>

* codegen

Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>

* missing codegen

Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>

* Update specification.md

Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>

* further clarify when to use new field

Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>

---------

Signed-off-by: cyrilico <19289022+cyrilico@users.noreply.github.com>
* seperate test reporting

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix file name path

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
… 1.27.27 (argoproj#3732)

chore(deps): bump github.com/aws/aws-sdk-go-v2/config

Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.26 to 1.27.27.
- [Release notes](https://github.com/aws/aws-sdk-go-v2/releases)
- [Commits](aws/aws-sdk-go-v2@config/v1.27.26...config/v1.27.27)

---
updated-dependencies:
- dependency-name: github.com/aws/aws-sdk-go-v2/config
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…j#3751)

* make sure config is used and only send merged coverage

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* checkout repo to get codecov config

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* use folder not file

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* disable search

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* switch merged output format

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* stop controller before upload

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* stop controller

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* stop controller

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* only stop on latest

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* print controller pids

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix erro

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add ls

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* kill correct process

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* add proper cover for unit to ues with merge

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* upload directory now

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
…oproj#3755)

Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3.5.0 to 3.6.1.
- [Release notes](https://github.com/docker/setup-buildx-action/releases)
- [Commits](docker/setup-buildx-action@aa33708...988b5a0)

---
updated-dependencies:
- dependency-name: docker/setup-buildx-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* docs: added clarifications for short releases

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: clarify current Argo Rollout behavior

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

* docs: also clarify multiple versions

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>

---------

Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
…ixes argoproj#3366 (argoproj#3639)

* Update pod status logic to support native sidecars

Signed-off-by: Martyn Dale <mdale@verticalscope.com>

* Fix lint issues

Signed-off-by: Martyn Dale <mdale@verticalscope.com>

---------

Signed-off-by: Martyn Dale <mdale@verticalscope.com>
Add Cloudflare to users

Signed-off-by: John Wood <jmw.home@gmail.com>
…#3766)

Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.21.0 to 0.22.0.
- [Commits](golang/oauth2@v0.21.0...v0.22.0)

---
updated-dependencies:
- dependency-name: golang.org/x/oauth2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Aleksander Korzynski <89802643+akorzy-pl@users.noreply.github.com>
argoproj#3664)

* fix(controller): use the stableRS from the rollout context rather than inferring it from the active selector, to deal with the edge case where the stableRS != activeRS during analysis templates

Signed-off-by: ben.minter <ben.minter@treatwell.com>

* fix(controller): update tests which were relying on this bug(?)

Signed-off-by: ben.minter <ben.minter@treatwell.com>

* fix(controller): add clarity to comment in the case there is no stableRS

Signed-off-by: ben.minter <ben.minter@treatwell.com>

* fix(controller): add a test to assert that the stablers is not scaled by the reconiliation on start, by checking the log

Signed-off-by: ben.minter <ben.minter@treatwell.com>

---------

Signed-off-by: ben.minter <ben.minter@treatwell.com>
…goproj#3775)

* feat: add rollout-transform-2023-10-09.yaml which has been adapted for kustomize v5

Signed-off-by: Jethro Lee <jethro.lee@a-bly.com>

* Rename to rollout-transform-kustomize-v5.yaml

Signed-off-by: Hidetake Iwata <int128@gmail.com>

* Add link to doc

Signed-off-by: Hidetake Iwata <int128@gmail.com>

---------

Signed-off-by: Jethro Lee <jethro.lee@a-bly.com>
Signed-off-by: Hidetake Iwata <int128@gmail.com>
Co-authored-by: Jethro Lee <jethro.lee@a-bly.com>
* making code for step plugin

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* codegen

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* unit tests

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* rpc tests

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* add rpc plugin tests

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* better message

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* add order test

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* implement terminate

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* Terminate tests

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* aborted logic + some unit test

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* unit test

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* abort test

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* load plugin

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* more tests

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* dont use newStatus

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* codegen preserve fields

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* some test before full promote problem

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix full promotion

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix plugins

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* codegen

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* add disabled rollout

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* codegen

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix duration cast

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* refactor to use context object

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* adding debug logs.

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* need to adjust the backoff on each reconcile

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix e2e

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* unit test

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix abort and promote logic

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* fix aborted rollout do not retry

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* add event

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* change enabled to status

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* unit tests

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* more test

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* cleanup

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* add docs

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* docs

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* makefile for e2e

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* disable e2e when not configured

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* Add some UI for the extension

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>

* codegen

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Co-authored-by: Zach Aller <zachaller@users.noreply.github.com>
…proj#3777)

Bumps [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer) from 3.5.0 to 3.6.0.
- [Release notes](https://github.com/sigstore/cosign-installer/releases)
- [Commits](sigstore/cosign-installer@59acb62...4959ce0)

---
updated-dependencies:
- dependency-name: sigstore/cosign-installer
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…roj#3776)

Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.5.0 to 6.6.1.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@5176d81...16ebe77)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Kevin Ji <1146876+kevinji@users.noreply.github.com>
Update ephemeral-metadata.md

A small grammatical fix.

Signed-off-by: Andy Reitz <ajr9@po.cwru.edu>
)

The current code creates a new http.Transport for each http.Client that is
created, which leads to a leak in TCP connections due to keep-alive.

Instead, reuse the same http.Transport between requests. According to the
http.Transport docs, this is safe for concurrent use.

Signed-off-by: Kevin Ji <1146876+kevinji@users.noreply.github.com>
Signed-off-by: Kostis Kapelonis <kostis@codefresh.io>
…j#3762) (argoproj#3784)

dco

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller zachaller force-pushed the fix-rs-conflict-with-fallback-to-patch-replicaset-refactor branch from 0e859c3 to 3f1e1e0 Compare August 13, 2024 14:22
dependabot bot and others added 5 commits August 13, 2024 10:42
…13.0 to 2.14.0 (argoproj#3786)

chore(deps): bump github.com/influxdata/influxdb-client-go/v2

Bumps [github.com/influxdata/influxdb-client-go/v2](https://github.com/influxdata/influxdb-client-go) from 2.13.0 to 2.14.0.
- [Release notes](https://github.com/influxdata/influxdb-client-go/releases)
- [Changelog](https://github.com/influxdata/influxdb-client-go/blob/master/CHANGELOG.md)
- [Commits](influxdata/influxdb-client-go@v2.13.0...v2.14.0)

---
updated-dependencies:
- dependency-name: github.com/influxdata/influxdb-client-go/v2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(controller): enable pprof profiling

Signed-off-by: John Wood <jmw.home@gmail.com>

* wip

Signed-off-by: John Wood <jmw.home@gmail.com>

* Consolidate --enable-pprof and --pprof-port into single config variable

Signed-off-by: John Wood <jmw.home@gmail.com>

---------

Signed-off-by: John Wood <jmw.home@gmail.com>
…s-conflict-with-fallback-to-patch-replicaset-refactor
* update changelog

* Update CHANGELOG.md

---------

Co-authored-by: zachaller <201390+zachaller@users.noreply.github.com>
Co-authored-by: Zach Aller <zachaller@users.noreply.github.com>
…s-conflict-with-fallback-to-patch-replicaset-refactor
Copy link

This PR is stale because it has been open 90 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.