fix: don't default datadog aggregator #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Go Published Test Results2 163 tests 2 163 ✅ 2m 54s ⏱️ Results for commit f4d60e0. ♻️ This comment has been updated with latest results. |
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3643 +/- ##
==========================================
- Coverage 80.25% 80.25% -0.01%
==========================================
Files 156 156
Lines 17966 17964 -2
==========================================
- Hits 14419 14417 -2
Misses 2634 2634
Partials 913 913 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 25m 28s ⏱️ For more details on these failures, see this check. Results for commit f4d60e0. |
zachaller
added a commit
that referenced
this pull request
Jun 17, 2024
* fix: don't default datadog aggregator Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * codegen Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> * fix: don't default datadog aggregator Signed-off-by: Zach Aller <zachaller@users.noreply.github.com> --------- Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
zachaller
added
cherry-pick-completed
2 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3641
Datadog API auto defaults to
avgso no need for us to have a default as well, and the default breaks backwards compatibility with v1.