Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rs conflict with fallback to patch replicaset refactor #3

Draft
wants to merge 84 commits into
base: fix-rs-conflict-with-fallback-to-patch
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
84 commits
Select commit Hold shift + click to select a range
ec18d99
fix: rs conflict with fallback to patch (#3559)
zachaller Jun 7, 2024
e807d39
chore(deps): bump github.com/aws/aws-sdk-go-v2 from 1.27.0 to 1.27.2 …
dependabot[bot] Jun 10, 2024
32d50b7
chore: add codecov token (#3623)
zachaller Jun 10, 2024
e20bcde
fix: verify the weight of the alb at the end of the rollout (#3627)
zachaller Jun 12, 2024
7df3d17
fix: when Rollout has pingpong and stable/canary service defined, onl…
mayzhang2000 Jun 12, 2024
1d5c9b4
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/elasticloadbal…
dependabot[bot] Jun 12, 2024
f656735
fix: protocol missing in ambassador canary mapping creation. Fixes #…
umjoshua Jun 12, 2024
0d3ed79
chore(deps): bump golang.org/x/oauth2 from 0.20.0 to 0.21.0 (#3631)
dependabot[bot] Jun 13, 2024
8bf1b5e
chore(deps): bump docker/build-push-action from 5.3.0 to 5.4.0 (#3624)
dependabot[bot] Jun 13, 2024
a2c7dbd
docs: Update Changelog (#3632)
github-actions[bot] Jun 13, 2024
11089c9
chore(deps): bump codecov/codecov-action from 4.4.1 to 4.5.0 (#3634)
dependabot[bot] Jun 14, 2024
8f32113
chore(deps): bump google.golang.org/protobuf from 1.34.1 to 1.34.2 (#…
dependabot[bot] Jun 14, 2024
84ef9f8
chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.16 to…
dependabot[bot] Jun 14, 2024
42cef17
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch fro…
dependabot[bot] Jun 14, 2024
7188d99
fix: Add volume for plugin and tmp folder (#3546)
tommy351 Jun 17, 2024
112dd4f
chore(deps): bump github.com/spf13/cobra from 1.8.0 to 1.8.1 (#3640)
dependabot[bot] Jun 17, 2024
b83ef70
chore: fix and add more cli usage case (#3592)
yyzxw Jun 17, 2024
d1ebbe9
fix: don't default datadog aggregator (#3643)
zachaller Jun 17, 2024
5a6ca83
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch fro…
dependabot[bot] Jun 18, 2024
50baf74
chore(deps): bump docker/build-push-action from 5.4.0 to 6.0.0 (#3644)
dependabot[bot] Jun 18, 2024
4f1edbe
chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.18 to…
dependabot[bot] Jun 18, 2024
f2b155d
chore: don't fail code-cov on failure (#3661)
zachaller Jun 21, 2024
72f3dab
chore(deps): bump docker/build-push-action from 6.0.0 to 6.0.2 (#3659)
dependabot[bot] Jun 21, 2024
c43f4fb
fix: docs site version selector broken (#3590)
yyzxw Jun 21, 2024
b5d0818
chore(deps): bump docker/build-push-action from 6.0.2 to 6.1.0 (#3662)
dependabot[bot] Jun 25, 2024
0c716e2
docs: Update Changelog (#3666)
github-actions[bot] Jun 25, 2024
f1d4dd2
chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.19 to…
dependabot[bot] Jun 27, 2024
5996471
chore(deps): bump docker/build-push-action from 6.1.0 to 6.2.0 (#3676)
dependabot[bot] Jun 27, 2024
f21956c
fix: add update verb to ClusterRole permissions for scaleDown feature…
EnriqueTejeda Jun 27, 2024
243ea91
fix(analysis): Take RollbackWindow into account when Reconciling Anal…
Psukhe Jun 27, 2024
04f8da1
chore(deps): bump softprops/action-gh-release from 2.0.5 to 2.0.6 (#3…
dependabot[bot] Jun 27, 2024
eb1d8b8
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch fro…
dependabot[bot] Jul 2, 2024
23436a2
chore(deps): bump github.com/aws/smithy-go from 1.20.2 to 1.20.3 (#3685)
dependabot[bot] Jul 2, 2024
b997674
chore: add example for updating all container images in set command (…
EnriqueTejeda Jul 2, 2024
aae86f7
chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.22 to…
dependabot[bot] Jul 3, 2024
590206b
chore(deps): bump google.golang.org/grpc from 1.64.0 to 1.65.0 (#3694)
dependabot[bot] Jul 3, 2024
68f7b41
chore(deps): bump docker/setup-buildx-action from 3.3.0 to 3.4.0 (#3705)
dependabot[bot] Jul 8, 2024
3e4ea74
feat(metricprovider): add prometheus range query support (#3704)
mclarke47 Jul 10, 2024
005ff27
chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.23 to…
dependabot[bot] Jul 10, 2024
2fad353
chore(deps): bump docker/build-push-action from 6.2.0 to 6.3.0 (#3697)
dependabot[bot] Jul 10, 2024
c366c5a
chore(deps): bump docker/setup-qemu-action from 3.0.0 to 3.1.0 (#3696)
dependabot[bot] Jul 10, 2024
764f530
docs: copy omission in rollout docs (#3690)
mathisto Jul 10, 2024
813b94c
chore(deps): bump github.com/aws/aws-sdk-go-v2/service/cloudwatch fro…
dependabot[bot] Jul 11, 2024
fdfc75e
chore(deps): bump actions/setup-go from 5.0.1 to 5.0.2 (#3716)
dependabot[bot] Jul 11, 2024
3d29653
chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.24 to…
dependabot[bot] Jul 11, 2024
d89abb2
feat(analysis): Returns the resolved query as metadata in the New Rel…
orlando-valdez-ck Jul 11, 2024
fdcb0d8
docs: correct the case that autoPromotionSeconds feature is ignored (…
itsme2980 Jul 11, 2024
e4c374d
chore(deps): bump docker/build-push-action from 6.3.0 to 6.4.0 (#3723)
dependabot[bot] Jul 16, 2024
d962435
fix(analysis): explicitly set datadog aggregator to last only on v2 (…
alexef Jul 18, 2024
1189944
chore(deps): bump docker/login-action from 3.2.0 to 3.3.0 (#3739)
dependabot[bot] Jul 23, 2024
9a230b3
chore(deps): bump docker/setup-buildx-action from 3.4.0 to 3.5.0 (#3738)
dependabot[bot] Jul 23, 2024
63c0eec
chore(deps): bump docker/build-push-action from 6.4.0 to 6.5.0 (#3737)
dependabot[bot] Jul 23, 2024
5dbd7a8
chore(deps): bump docker/setup-qemu-action from 3.1.0 to 3.2.0 (#3736)
dependabot[bot] Jul 23, 2024
c727a3c
chore: code coverage for e2e (#3740)
zachaller Jul 24, 2024
f96eaca
chore(deps): bump softprops/action-gh-release from 2.0.6 to 2.0.8 (#3…
dependabot[bot] Jul 24, 2024
9884b2a
fix: e2e test results processing change key name to run-id (#3744)
zachaller Jul 24, 2024
d3d630d
fix: add secrets so we can download across workflows (#3746)
zachaller Jul 24, 2024
872f2ac
feat(controller): Allow specifying full annotations for nginx canary …
cyrilico Jul 25, 2024
638ca1b
fix: separate e2e and unit test reporting uploads (#3747)
zachaller Jul 25, 2024
e638c88
chore(deps): bump github.com/aws/aws-sdk-go-v2/config from 1.27.26 to…
dependabot[bot] Jul 25, 2024
3024c2a
chore: use codecov config and only send merged coverage file (#3751)
zachaller Jul 29, 2024
65fc9ef
chore(deps): bump docker/setup-buildx-action from 3.5.0 to 3.6.1 (#3755)
dependabot[bot] Jul 30, 2024
643d684
docs: added clarifications for short releases (#3753)
kostis-codefresh Jul 31, 2024
6c873a9
fix(dashboard): Update pod status logic to support native sidecars. F…
martynd Jul 31, 2024
708db68
fix(controller): Get the right resourceName for traefik.io.Fixes #361…
BrunoTarijon Aug 1, 2024
f2c737c
chore: Add Cloudflare to users (#3768)
johnmwood Aug 6, 2024
cf46983
chore(deps): bump golang.org/x/oauth2 from 0.21.0 to 0.22.0 (#3766)
dependabot[bot] Aug 6, 2024
0ca5932
docs: add Priceline to USERS.md (#3764)
akorzy-pl Aug 6, 2024
827ce59
fix(controller): use the stableRS from the rollout context rather tha…
benminter-treatwell Aug 6, 2024
48131eb
fix: Support kustomize v5 labels transformer. Fixes #3105 (#3775)
int128 Aug 7, 2024
74c1a94
feat(controller): add canary steps plugin (#3521)
agaudreault Aug 8, 2024
b448b76
chore(deps): bump sigstore/cosign-installer from 3.5.0 to 3.6.0 (#3777)
dependabot[bot] Aug 8, 2024
825a7ca
chore(deps): bump docker/build-push-action from 6.5.0 to 6.6.1 (#3776)
dependabot[bot] Aug 8, 2024
54cef88
chore: capitalize AS in Dockerfile (#3781)
kevinji Aug 12, 2024
8f74229
docs: Update ephemeral-metadata.md with a small fix (#3782)
areitz Aug 12, 2024
6b2ee92
fix(metricprovider): reuse http.Transport for http.Client (#3780)
kevinji Aug 12, 2024
f6ce5ce
docs: remove obsolete roadmap page (#3783)
kostis-codefresh Aug 12, 2024
3c15eb1
fix: replicaSet not scaled down due to incorrect annotations (#3762) …
agaudreault Aug 12, 2024
3f1e1e0
refactor replicaset creation
zachaller Aug 13, 2024
e619a51
chore(deps): bump github.com/influxdata/influxdb-client-go/v2 from 2.…
dependabot[bot] Aug 13, 2024
0397210
feat(controller): enable pprof profiling support (#3769)
johnmwood Aug 13, 2024
1990049
Merge branch 'master' of github.com:argoproj/argo-rollouts into fix-r…
zachaller Aug 13, 2024
36b9e15
docs: Update Changelog (#3788)
github-actions[bot] Aug 13, 2024
8c0e048
Merge branch 'master' of github.com:argoproj/argo-rollouts into fix-r…
zachaller Aug 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .codecov.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,5 @@ ignore:
- 'pkg/client/.*'
- 'vendor/.*'
- '**/mocks/*'
- 'hack/gen-crd-spec/main.go'
- 'hack/gen-docs/main.go'
98 changes: 0 additions & 98 deletions .github/workflows/e2e.yaml

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/gh-pages.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
with:
python-version: 3.x
- name: Set up Go
uses: actions/setup-go@v5.0.1
uses: actions/setup-go@v5.0.2
with:
go-version: '1.22'
- name: build
Expand Down
37 changes: 3 additions & 34 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,6 @@ permissions:
contents: read

jobs:
event_file:
name: 'Event File'
runs-on: ubuntu-latest
steps:
- name: Upload
uses: actions/upload-artifact@v4
with:
name: Event File
path: ${{ github.event_path }}
lint-go:
permissions:
contents: read # for actions/checkout to fetch code
Expand All @@ -36,7 +27,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Set up Go
uses: actions/setup-go@v5.0.1
uses: actions/setup-go@v5.0.2
with:
go-version: ${{ env.GOLANG_VERSION }}
- name: Checkout code
Expand All @@ -51,7 +42,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Set up Go
uses: actions/setup-go@v5.0.1
uses: actions/setup-go@v5.0.2
with:
go-version: ${{ env.GOLANG_VERSION }}
id: go
Expand All @@ -72,28 +63,6 @@ jobs:
- name: Compile all packages
run: make controller plugin

- name: Test
run: make test-unit

- name: Upload Unit Test Results
if: always()
uses: actions/upload-artifact@v4
with:
name: Unit Test Results
path: |
junit.xml

- name: Generate code coverage artifacts
uses: actions/upload-artifact@v4
with:
name: code-coverage
path: coverage.out

- name: Upload code coverage information to codecov.io
uses: codecov/codecov-action@v4.4.1
with:
file: coverage.out

codegen:
name: Verify Codegen
runs-on: ubuntu-latest
Expand All @@ -103,7 +72,7 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4
- name: Setup Golang
uses: actions/setup-go@v5.0.1
uses: actions/setup-go@v5.0.2
with:
go-version: ${{ env.GOLANG_VERSION }}
# k8s codegen generates files into GOPATH location instead of the GitHub git checkout location
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/image-reuse.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,17 @@ jobs:
if: ${{ github.ref_type != 'tag'}}

- name: Setup Golang
uses: actions/setup-go@v5.0.1 # v3.5.0
uses: actions/setup-go@v5.0.2 # v3.5.0
with:
go-version: ${{ inputs.go-version }}

- name: Install cosign
uses: sigstore/cosign-installer@59acb6260d9c0ba8f4a2f9d9b48431a222b68e20 # v3.5.0
uses: sigstore/cosign-installer@4959ce089c160fddf62f7b42464195ba1a56d382 # v3.6.0
with:
cosign-release: 'v2.2.0'

- uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0
- uses: docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb # v3.3.0
- uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf # v3.2.0
- uses: docker/setup-buildx-action@988b5a0280414f521da01fcc63a27aeeb4b104db # v3.6.1

- name: Setup tags for container image as a CSV type
run: |
Expand All @@ -106,31 +106,31 @@ jobs:
echo 'EOF' >> $GITHUB_ENV

- name: Login to Quay.io
uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
with:
registry: quay.io
username: ${{ secrets.quay_username }}
password: ${{ secrets.quay_password }}
if: ${{ inputs.quay_image_name && inputs.push }}

- name: Login to GitHub Container Registry
uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
with:
registry: ghcr.io
username: ${{ secrets.ghcr_username }}
password: ${{ secrets.ghcr_password }}
if: ${{ inputs.ghcr_image_name && inputs.push }}

- name: Login to dockerhub Container Registry
uses: docker/login-action@0d4c9c5ea7693da7b068278f7b52bda2a190a446 # v3.2.0
uses: docker/login-action@9780b0c442fbb1117ed29e0efdff1e18412f7567 # v3.3.0
with:
username: ${{ secrets.docker_username }}
password: ${{ secrets.docker_password }}
if: ${{ inputs.docker_image_name && inputs.push }}

- name: Build and push container image
id: image
uses: docker/build-push-action@2cdde995de11925a030ce8070c3d77a52ffcf1c0 #v5.3.0
uses: docker/build-push-action@16ebe778df0e7752d2cfcbd924afdbbd89c1a755 #v6.6.1
with:
context: .
platforms: ${{ inputs.platforms }}
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,15 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Setup Golang
uses: actions/setup-go@v5.0.1 # v4.0.1
uses: actions/setup-go@v5.0.2 # v4.0.1
with:
go-version: ${{ env.GOLANG_VERSION }}

- name: Set up QEMU
uses: docker/setup-qemu-action@68827325e0b33c7199eb31dd4e31fbe9023e06e3 # v3.0.0
uses: docker/setup-qemu-action@49b3bc8e6bdd4a60e6116a5414239cba5943d3cf # v3.2.0

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@d70bba72b1f3fd22344832f00baa16ece964efeb # v3.3.0
uses: docker/setup-buildx-action@988b5a0280414f521da01fcc63a27aeeb4b104db # v3.6.1

- name: Generate release artifacts
run: |
Expand All @@ -107,7 +107,7 @@ jobs:
make manifests IMAGE_TAG=${{ github.ref_name }}

- name: Draft release
uses: softprops/action-gh-release@69320dbe05506a9a39fc8ae11030b214ec2d1f87 # v0.1.15
uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v0.1.15
with:
tag_name: ${{ github.event.inputs.tag }}
draft: true
Expand Down Expand Up @@ -163,12 +163,12 @@ jobs:
token: ${{ secrets.GITHUB_TOKEN }}

- name: Setup Golang
uses: actions/setup-go@v5.0.1 # v4.0.0
uses: actions/setup-go@v5.0.2 # v4.0.0
with:
go-version: ${{ env.GOLANG_VERSION }}

- name: Install cosign
uses: sigstore/cosign-installer@59acb6260d9c0ba8f4a2f9d9b48431a222b68e20 # v3.5.0
uses: sigstore/cosign-installer@4959ce089c160fddf62f7b42464195ba1a56d382 # v3.6.0
with:
cosign-release: 'v2.2.0'

Expand Down Expand Up @@ -212,7 +212,7 @@ jobs:
/tmp/sbom.tar.gz

- name: Upload SBOM and signature assets
uses: softprops/action-gh-release@69320dbe05506a9a39fc8ae11030b214ec2d1f87 # v0.1.15
uses: softprops/action-gh-release@c062e08bd532815e2082a85e87e3ef29c3e6d191 # v0.1.15
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
# use separate workflow to support fork repositories and dependabot branches when publishing test results: see https://github.com/EnricoMi/publish-unit-test-result-action#support-fork-repositories-and-dependabot-branches
name: Test Results
name: Testing Results

on:
workflow_run:
workflows: ["E2E Tests", "Go"]
workflows: ["Testing"]
types:
- completed
permissions: {}
Expand All @@ -19,27 +19,31 @@ jobs:
actions: read
steps:
- name: Download and Extract Artifacts
# TODO repace with native actions/download-artifact once it supports downloading from another workflow: https://github.com/actions/download-artifact/issues/3
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
run: |
mkdir -p artifacts && cd artifacts
artifacts_url=${{ github.event.workflow_run.artifacts_url }}
gh api "$artifacts_url" -q '.artifacts[] | [.name, .archive_download_url] | @tsv' | while read artifact
do
IFS=$'\t' read name url <<< "$artifact"
gh api $url > "$name.zip"
unzip -d "$name" "$name.zip"
done
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
with:
run-id: ${{ github.event.workflow_run.id }}
path: artifacts
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: Publish Test Results
- name: Publish E2E Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
with:
check_name: "${{ github.event.workflow.name }} Published Test Results"
check_name: "Published E2E Test Results"
compare_to_earlier_commit: false
test_changes_limit: 0
fail_on: "errors"
commit: ${{ github.event.workflow_run.head_sha }}
event_file: artifacts/Event File/event.json
event_name: ${{ github.event.workflow_run.event }}
junit_files: "artifacts/**/junit.xml"
files: "artifacts/**/junit-e2e-test.xml"
- name: Publish Unit Test Results
uses: EnricoMi/publish-unit-test-result-action@v2
with:
check_name: "Published Unit Test Results"
compare_to_earlier_commit: false
test_changes_limit: 0
fail_on: "errors"
commit: ${{ github.event.workflow_run.head_sha }}
event_file: artifacts/Event File/event.json
event_name: ${{ github.event.workflow_run.event }}
files: "artifacts/**/junit-unit-test.xml"
Loading
Loading