Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: separate e2e and unit test reporting uploads #3747

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Jul 25, 2024

Report the status of E2E and unit tests seperatly to maintain the same behavior as before, a comment for each one on the PR.

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
@zachaller zachaller force-pushed the seperate-test-reporting branch from 883080d to f3ab2d2 Compare July 25, 2024 01:00
Copy link

@zachaller zachaller changed the title fix: separate test reporting uploads fix: separate e2e and unit test reporting uploads Jul 25, 2024
Copy link
Contributor

Testing Published Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit f3ab2d2.

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (d3d630d) to head (f3ab2d2).
Report is 68 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3747      +/-   ##
==========================================
+ Coverage   78.15%   78.16%   +0.01%     
==========================================
  Files         157      157              
  Lines       22501    22501              
==========================================
+ Hits        17585    17588       +3     
+ Misses       4002     3999       -3     
  Partials      914      914              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 638ca1b into argoproj:master Jul 25, 2024
26 checks passed
nikoshet pushed a commit to nikoshet/argo-rollouts that referenced this pull request Jul 25, 2024
* seperate test reporting

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix file name path

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
nikoshet pushed a commit to nikoshet/argo-rollouts that referenced this pull request Jul 25, 2024
* seperate test reporting

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

* fix file name path

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>

---------

Signed-off-by: Zach Aller <zachaller@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants