Pre Release (v3.9.0-beta.6): git_revision.cをどうにかする #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
あとは |
|
え，S2E系のCIだけ落ちてる...まさか... |
sksat
force-pushed
the
feature/refactor-git-revision
branch
from
ecc2537 to
13577d1
Compare
|
|
|
|
sksat
force-pushed
the
feature/refactor-git-revision
branch
from
13577d1 to
a320840
Compare
|
conflictしてたのでrebase |
|
再rebase |
sksat
force-pushed
the
feature/refactor-git-revision
branch
from
a320840 to
6c49026
Compare
|
あと微塵もLibraryではないし |
|
というか |
|
coreに |
|
というかそれなら |
|
いや |
sksat
force-pushed
the
feature/refactor-git-revision
branch
from
6c49026 to
ad276ca
Compare
Examples/minimum_user_for_s2e/src/src_user/Script/git_revision.bat
Outdated
Show resolved
Hide resolved
|
あ，conflictしてるんでrebase |
sksat
force-pushed
the
feature/refactor-git-revision
branch
from
05cbafc to
742d94b
Compare
|
これなんで |
|
|
|
まあ |
|
descriptionを修正 |
sksat
force-pushed
the
feature/refactor-git-revision
branch
from
073721c to
6765b55
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
2nd obc とおなじものはこれに追記 \c2a-core\Examples\2nd_obc_user\sync_with_minimum_user.bat |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Examples/2nd_obc_user/src/src_user/Settings/git_revision_config.h
Outdated
Show resolved
Hide resolved
Examples/2nd_obc_user/src/src_user/Settings/git_revision_config.h
Outdated
Show resolved
Hide resolved
Examples/2nd_obc_user/src/src_user/Settings/git_revision_config.h
Outdated
Show resolved
Hide resolved
meltingrabbit
changed the title
meltingrabbit
requested changes
May 17, 2023
|
2年越しのマージ |
20 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
git_revision.cがトラッキングされていると，ビルドする度に無意味なdiffが発生する上誤ってcommitしてしまうことがある．そのため，
git_revision.cを生成するのではなく，コンパイルオプションに渡してdefineすることでgit revisionを埋め込むようにする．Issue
NA
詳細
git_revision.cはGIT_REVISION_C2A_COREのような定数を埋め込むだけにするgit_revision.hをsrc_core/Libraryに移したgit_revision.cをc2a_core_main.c内部に移した"0000000000000000000000000000000000000000"などが入る検証結果
NA
影響範囲
詳しくはExample minimum userの
src_user/Settings/git_revision_config.hを参照のこと．src/src_user/Library/git_revision.cではなくsrc/src_core/git_revision.cを使うようにするadd_subdirectory()するだけでOK(userのCMakeLists.txtからgit_revision.cを消せばいい)src_user/Settings/git_revision_config.hでC2A_GIT_REVISION_FROM_OPTIONを定義するgit_revision.cを自動生成していた環境Examples/minimum_user_for_s2e/src/src_user/Script/git_revision.batExamples/minimum_user_for_s2e/src/src_user/Script/Git/revision.batsrc_user/Settings/git_revision_config.hでC2A_GIT_REVISION_IGNOREをdefineする補足