Pre Release (v3.9.0-beta.8): Fix get c2a-core git revision working dir #600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
#82 で追加した CMake での git revision 出力のうち,c2a-core 部分が間違っていたので修正
Issue/PR
詳細
src/src_core
)で行う必要があるCMAKE_CURRENT_SOURCE_DIR
)ではなくビルド時の context でのソースディレクトリ(CMAKE_SOURCE_DIR
)になっていたadd_subdirectory()
で c2a-core を読み込んでビルドしているような環境では,core の revision として user の revision が取り入れられてしまっていた検証結果
影響範囲
c2a-core を CMake の
add_subdirectory
で使っているような環境補足
pre release 打ちたい