Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git revision 用の bat ファイルを修正 #596

Merged
merged 2 commits into from
May 24, 2023

Conversation

chutaro
Copy link
Contributor

@chutaro chutaro commented May 24, 2023

概要

git revision 用の bat ファイルを修正

Issue / PR

詳細

詳しくは diff を参照

@chutaro chutaro added the priority::high priorityg high label May 24, 2023
@chutaro chutaro requested a review from sksat May 24, 2023 09:01
@chutaro chutaro self-assigned this May 24, 2023
@sksat
Copy link
Collaborator

sksat commented May 24, 2023

ああ,これ #82 で僕が書いたバッチファイルのミスですね.ありがとうございます.

@sksat
Copy link
Collaborator

sksat commented May 24, 2023

修正内容については妥当だと思うので,user 側のバッチファイルを 2nd obc user にもコピーしてもらえれば approve します

@sksat
Copy link
Collaborator

sksat commented May 24, 2023

FYI: こういう場合,commit message は modify より fix みたいな語を入れた方がよいです(modify は変更したことしか伝わらないので)

@chutaro
Copy link
Contributor Author

chutaro commented May 24, 2023

FYI: こういう場合,commit message は modify より fix みたいな語を入れた方がよいです(modify は変更したことしか伝わらないので)

なるほどです、ありがとうございます!

@chutaro
Copy link
Contributor Author

chutaro commented May 24, 2023

2nd obc も修正しました

@chutaro chutaro merged commit 042cdfa into develop May 24, 2023
@chutaro chutaro deleted the feature/modify_git_revision branch May 24, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority::high priorityg high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants