Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

自身のOBCのテレメを生成する Cmd_TG_GENERATE_TLM と便利エイリアスの実装 #541

Merged
merged 5 commits into from
Apr 20, 2023
Merged

自身のOBCのテレメを生成する Cmd_TG_GENERATE_TLM と便利エイリアスの実装 #541

merged 5 commits into from
Apr 20, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Apr 11, 2023 •
edited
Loading

概要

自身のOBCのテレメを生成する Cmd_TG_GENERATE_TLM と便利エイリアスの実装

Issue

詳細

検証結果

影響範囲

Cmd_GENERATE_TLM が deprecated

備考

@meltingrabbit meltingrabbit added enhancement New feature or request priority::high priorityg high labels Apr 11, 2023
@meltingrabbit meltingrabbit self-assigned this Apr 11, 2023
@meltingrabbit meltingrabbit changed the title WIP: 自身のOBCのテレメを生成する Cmd_TG_GENERATE_TLM と便利エイリアスの実装 自身のOBCのテレメを生成する Cmd_TG_GENERATE_TLM と便利エイリアスの実装 Apr 11, 2023
@meltingrabbit meltingrabbit changed the base branch from develop to feature/remove_APID_is_other_obc_tlm_apid April 11, 2023 02:51
@meltingrabbit meltingrabbit mentioned this pull request Apr 11, 2023
Merged
3 tasks
chutaro
chutaro reviewed Apr 19, 2023
View reviewed changes
TlmCmd/telemetry_generator.c Show resolved Hide resolved
TlmCmd/telemetry_generator.c Outdated Show resolved Hide resolved
TlmCmd/telemetry_generator.c Show resolved Hide resolved
TlmCmd/telemetry_generator.c Show resolved Hide resolved
@meltingrabbit meltingrabbit mentioned this pull request Apr 19, 2023
Closed
chutaro
chutaro approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@chutaro chutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approveしました

@meltingrabbit
Copy link
Collaborator Author

ありがとう！
#544 の approve 後に pytest 通し直してからマージします！

Base automatically changed from feature/remove_APID_is_other_obc_tlm_apid to develop April 20, 2023 01:57
@meltingrabbit meltingrabbit merged commit 45b3481 into develop Apr 20, 2023
@meltingrabbit meltingrabbit deleted the feature/generate_tlm branch April 20, 2023 02:22
@meltingrabbit meltingrabbit mentioned this pull request Apr 20, 2023
Closed
@chutaro chutaro mentioned this pull request May 26, 2023
Merged
20 tasks
@meltingrabbit meltingrabbit mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutaro chutaro chutaro approved these changes

@flap1 flap1 Awaiting requested review from flap1

@ToshiAki64 ToshiAki64 Awaiting requested review from ToshiAki64

Assignees

@meltingrabbit meltingrabbit

Labels
enhancement New feature or request priority::high priorityg high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @chutaro