Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APID_is_other_obc_tlm_apid の削除 #535

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Apr 10, 2023

概要

APID_is_other_obc_tlm_apid の削除

Issue

詳細

メンテ性が最悪なこの関数を削除

この後,満を持して,generate tlmの改修にはいる

検証結果

MOBCとAOBC (2nd OBC) で,きちんと CTP の primary header が区別されていることを手元で確認した

影響範囲

APID_is_other_obc_tlm_apid をすべて削除することができる

Copy link
Contributor

@chutaro chutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです!

@meltingrabbit meltingrabbit merged commit 24813f3 into develop Apr 20, 2023
@meltingrabbit meltingrabbit deleted the feature/remove_APID_is_other_obc_tlm_apid branch April 20, 2023 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority::high priorityg high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants