Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre Release (v3.9.0-beta.1): Cmd_TG_FORWARD_TLM の実装 #544

Merged
merged 19 commits into from
Apr 20, 2023
Merged

Pre Release (v3.9.0-beta.1): Cmd_TG_FORWARD_TLM の実装 #544

merged 19 commits into from
Apr 20, 2023

Conversation

meltingrabbit
Copy link
Collaborator

@meltingrabbit meltingrabbit commented Apr 11, 2023 •
edited
Loading

概要

Pre Release (v3.9.0-beta.1): Cmd_TG_FORWARD_TLM の実装

Issue

詳細

以下とともにマージする

検証結果

  • 既存の pytest が全て通った（2nd OBC test は通るように修正した）

影響範囲

GENERATE_TLM 系コマンドでは，2nd obc のテレメの転送ができなくなる

備考

補足

  • この後に，さらに細かい微修正を追加する可能性がある
  • WINGS API の /api/operations/{}/tlm が未対応なため，tlm id が重なった場合，WINGS API でのテレメ取得は未定義となる

@meltingrabbit meltingrabbit added enhancement New feature or request priority::high priorityg high tools labels Apr 11, 2023
@meltingrabbit meltingrabbit self-assigned this Apr 11, 2023
@meltingrabbit meltingrabbit mentioned this pull request Apr 16, 2023
Merged
1 task
@meltingrabbit meltingrabbit changed the title WIP: Cmd_TG_FORWARD_TLM の実装 Pre Release (v3.9.0-beta.1): Cmd_TG_FORWARD_TLM の実装 Apr 16, 2023
@meltingrabbit meltingrabbit mentioned this pull request Apr 16, 2023
Merged
1 task
meltingrabbit
meltingrabbit commented Apr 16, 2023
View reviewed changes
TlmCmd/telemetry_generator.c Outdated
// Primary Header → 維持

// Secondary Header
if ((uint64_t)TSP_get_global_time(&TG_ctp_) == 0xffffffffffffffffULL)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sksat CI に u64 のリテラル表現はだめ，と怒られるんだけど，これいいワークアラウンドありませんかね？

/home/runner/work/c2a-core/c2a-core/repo/Examples/minimum_user/src/src_core/TlmCmd/telemetry_generator.c:308:50: error: 'long long' is an extension when C99 mode is not enabled [-Werror,-Wlong-long]
  if ((uint64_t)TSP_get_global_time(&TG_ctp_) == 0xffffffffffffffffULL)
                                                 ^

@meltingrabbit
Copy link
Collaborator Author

送出回数は，utilのほうはけす

@meltingrabbit meltingrabbit mentioned this pull request Apr 19, 2023
Merged
1 task
chutaro
chutaro approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@chutaro chutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

よさそうです。お疲れ様です！

@meltingrabbit
Copy link
Collaborator Author

ありがとうございます！
念のため最後にもう一度pytestまわし，Tools側のapproveたまったらマージします

Base automatically changed from feature/generate_tlm to develop April 20, 2023 02:22
@meltingrabbit meltingrabbit merged commit afd6ee3 into develop Apr 20, 2023
@meltingrabbit meltingrabbit deleted the feature/forward_tlm branch April 20, 2023 04:16
This was referenced Apr 20, 2023
Closed
Closed
@chutaro chutaro mentioned this pull request May 26, 2023
Merged
20 tasks
@meltingrabbit meltingrabbit mentioned this pull request Jun 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chutaro chutaro chutaro approved these changes

@flap1 flap1 Awaiting requested review from flap1

@ToshiAki64 ToshiAki64 Awaiting requested review from ToshiAki64

Assignees

@meltingrabbit meltingrabbit

Labels
enhancement New feature or request priority::high priorityg high tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltingrabbit @chutaro