Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RIF from m_rifsToAdd before deleting it - BUILDIMAGE to TEST #26

Open
wants to merge 217 commits into
base: master
Choose a base branch
from

Conversation

tshalvi
Copy link
Owner

@tshalvi tshalvi commented Sep 24, 2024

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

dgsudharsan and others added 30 commits June 7, 2024 04:01
…8.0.30 (sonic-net#19198)

- Why I did it
Updating SDK/FW to 4.6.4062/2012.4062
SAI to SAIBuild2405.28.0.30

- How I did it
Updating Makefiles

- How to verify it
Running sonic-mgmt tests
Mask Watchdog-control.service and make sure only one watchdog service
starts on this platform
- Why I did it
Integrate HW-MGMT 7.0030.4003 Changes
Requires sonic-net/sonic-linux-kernel#396

- How I did it
Run make integrate-mlnx-hw-mgmt

- How to verify it
Build an image and run tests from "sonic-mgmt".
Disable TPM module for SN5600 and SN5400 to avoid following error message:

ERR kernel: [    3.434153] tpm tpm0: [Firmware Bug]: TPM interrupt not working, polling instead
Microsoft ADO (number only): 28321093

Loaded sonic image with this SAI version on chassis device, dockers are up, no crash
User implications:
On cold/warm/fast reboot if there is a syncd service start ongoing, the target procedure will stay blocked until the original call is done. This may delay the action in time.

- Why I did it
Improve the upgrade fw script avoiding errors in the logs when cold reboot is executed during service restart
Work item tracking

- How I did it
Added locking mechanism for Mellanox FW upgrade

- How to verify it
Run cold reboot after DUT first install

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
[arp_update]: Use parent script PID for logger calls

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
- Why I did it
Previously, the PSU sensor configuration inside sensors.conf is hardcoded for each platform, allowing no flexibility for other PSU combination possibilities. However, there exists a scenario that user has a second source of PSU which has different sensors compared to the original sensors.conf. Thereby it requires the system to have the ability to dynamically detect the PSU model in using and load relevant sensor’s configuration file.

- How I did it
This PR involves a new script and a corresponding data file which contains all PSU model’s sensor configuration info. The script reads the hardware PSU information through hw-management and determines its model. Based on that, it searches for the corresponding pre-defined PSU sensor data, integrate them into the sensors.conf, and let PMON copy it for further loading by lm-sensor.

It also integrates the script inside the platform's get_model() API. Therefore, each time this API is called by the psud code, it checks whether there has been a change in the PSU model. If a change is detected, it updates the PSU sensors configuration by calling the script.

- How to verify it
use sensors command and check the psu section is rightly labeled.

Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
Why I did it
A new flag was introduced in sonic-net/sonic-linkmgrd#250 to disable mux oscillations but yang model wasn't updated. We are seeing multiple tests failing due to this, some of them are -

generic_config_updater/test_dynamic_acl.py
passw_hardening/test_passw_hardening.py
dualtor_mgmt/test_toggle_mux.py
- Why I did it
Support Mellanox-SN5600-V256

- How I did it
Add relevant files to support the new SKU

- How to verify it
Regression test
…minigraph (sonic-net#19160)

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : sonic-net#19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Why I did it
Fix sonic-net#19081
We have used gnmi container to replace telemetry container, and telemetry is still enabled after upgrade.
service_checker script reads from features table and check if the container is running, telemetry is enabled but there's no telemetry container.
It's difficult to disable telemetry in feature table for warm reboot and cold reboot, we need to check docker image in db migrator and minigraph.py.
When we use warm reboot to upgrade from 202305 to 202311, config_db still has telemetry configuration, and we can't simply remove related configuration.

Work item tracking
Microsoft ADO (number only):
How I did it
I modify service_checker script:
If there's docker-sonic-telemetry image, check telemetry container.
If there's no docker-sonic-telemetry image, check gnmi container instead.
If there's no docker-sonic-telemetry image and docker-sonic-gnmi image, do not check telemetry.

How to verify it
Run unit test and end to end test.
…'s sai.profile (sonic-net#19261)

- Why I did it
Two steps (among others) are required to enable the host CMIS management feature: enabling it in the switch's sai.profile and performing a config reload. During the timeframe between these two steps, the control sysfs might be accessed, but they will not be present on the system until the latter step, the config reload, is completed. The code should try to access the control sysfs only after the config reload step. A good indication that this has been done is to check if the relevant entry is included in syncd's sai.profile. In contrast to the switch's sai.profile, syncd's sai.profile is only updated with the Host CMIS management support flag after the reload is complete.

- How I did it
I updated the is_module_host_management_mode() implementation to first look for the Host CMIS management support flag in syncd's sai.profile, and only if it does not exist for some reason, look for it in the switch's sai.profile.

- How to verify it
Add the Host CMIS management support flag to the switch's sai.profile and verify that the following log does not appear:
ERR pmon#xcvrd: Exception occured at DomInfoUpdateTask thread due to Exception('control sysfs for SFP 20 does not exist')
Why I did it
Fix build error when enable restapi and debug.
the derived package function is not called correctly.

Work item tracking
Microsoft ADO (number only): 28376451
How I did it
How to verify it
Signed-off-by: anamehra anamehra@cisco.com

Cisco platform 202405.0.1 release
Why I did it
DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario.

How I did it
When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.

Co-authored-by: Liu Shilong <shilongliu@microsoft.com>
…9407)

- Why I did it
Add the force flag to the reboot, which is needed now that we no longer use power cycle due to # 18325

- How I did it
Update the onie fw update script to use efibootmgr for the supported devices, and on the reboot command, call the reboot script with the f flag.

- How to verify it
Run ONIE upgrade using fwutil
Signed-off-by: anamehra anamehra@cisco.com

Cisco platform 202405.0.2 release
Why I did it
Currently yang pattern is restricting interfaces to those that start with Ethernet however interfaces that discard can start with "eth", "Vlan", "PortChannel", and others as well.

How I did it
Update YANG file and UT

How to verify it
sonic-mgmt test and UT
…onic-net#19413)

What I did:-
Populate bgp_asn in DEVICE_METADATA only if is present/valid.

Why I did:
Without this it causes Yang Validation failure for Systems that are Pure
L2/Chassis Supervisor (no BGP) as Yang expects bgp_asn as valid
as_number

---------

Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
… Smart Switch. (sonic-net#19200)

The configuration generated from the template for the Smart Switch contained incorrect data in the "subnet4:id" field. For regular cases, the subnet ID is deduced from the VLAN name. For the Smart Switch, there is always one subnet, and the ID is set to 0.
Signed-off-by: zitingguo-ms <zitingguo@microsoft.com>
Why I did it
Fix issue that dhcp_server doesn't create syslog into host sonic-net#18472

Work item tracking
Microsoft ADO (number only): 28396389
How I did it
Modify rsyslog config template

How to verify it
UTs passed
Buildimage and install in testbed to verify
…omatically (sonic-net#19555)

#### Why I did it
src/sonic-swss-common
```
* 1ca2fe5 - (HEAD -> 202405, origin/202405) Revert "Temporarily skip vstest (sonic-net#891)" (sonic-net#892) (26 hours ago) [Jianquan Ye]
* 11c68d8 - Temporarily skip vstest (sonic-net#891) (26 hours ago) [Jianquan Ye]
```
#### How I did it
#### How to verify it
#### Description for the changelog
…lly (sonic-net#19554)

#### Why I did it
src/sonic-swss
```
* d3073b7c - (HEAD -> 202405, origin/202405) [muxorch] Fixing bug with updateRoute and mux neighbors (sonic-net#3187) (19 hours ago) [Nikola Dancejic]
* b16d6b2a - ADD VOQ COUNTERS(SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP, SAI_QUEUE_ST…T_CREDIT_WD_DELETED_PACKETS) support for VOQ/Fabric switches (sonic-net#3152) (19 hours ago) [saksarav-nokia]
* 12a95e57 - Revamp module build script to make it work for 5.15 on Ubuntu 20.04 (sonic-net#3212) (19 hours ago) [Saikrishna Arcot]
* 87cf38e0 - Fix in switchorch: unsupported attribute causes skipping of processing the rest of configurations (sonic-net#3209) (19 hours ago) [Amir]
* 8f333b69 - [subnet decap] Support decap rule generation based on T0 VIP route (sonic-net#3183) (5 weeks ago) [Longxiang Lyu]
* 9bcb9b6e - Fixing appl_db FABRIC_MONITOR notification issue. (sonic-net#3176) (5 weeks ago) [jfeng-arista]
* fff544e6 - Rotate record file before writing new log. (sonic-net#3158) (5 weeks ago) [mint570]
* 80f52079 - Add SWSS support for link event damping feature (sonic-net#2933) (5 weeks ago) [Roy Yi]
* b3ebfc46 - [muxorch] Using bulker to program routes/neighbors during switchover (sonic-net#3148) (5 weeks ago) [Nikola Dancejic]
```
#### How I did it
#### How to verify it
#### Description for the changelog
…D automatically (sonic-net#19553)

#### Why I did it
src/sonic-platform-daemons
```
* 41b1c82 - (HEAD -> 202405, origin/202405) [CMIS] Skip re-init flow for SW-controlled ports in case of fastboot (sonic-net#497) (4 weeks ago) [Stepan Blyshchak]
```
#### How I did it
#### How to verify it
#### Description for the changelog
…tically (sonic-net#19550)

#### Why I did it
src/sonic-dash-api
```
* 1fd0b7d - (HEAD -> 202405, origin/202405) [202405 build] Update pool sonicbld to sonic-ububtu-1c since it's deprecated (#22) (11 days ago) [Jianquan Ye]
```
#### How I did it
#### How to verify it
#### Description for the changelog
yaqiangz and others added 30 commits September 21, 2024 07:01
…er config (sonic-net#20227)

Why I did it
Switch cannot connect to NTP server with Loopback ipv6 in Loopback ipv6 only scenario.

Work item tracking
Microsoft ADO (number only): 29415265

How I did it
Add support for ntp to listen ipv4/ipv6 address depends on server config

How to verify it
Run ntp test with new template
### Why I did it
The new added attributes related fabric link monitoring are missing YANG model. Adding them in this change. 

For fabric monitor table: 
> monCapacityThreshWarn
> monState

For fabric port:
> forceUnisolateStatus
Signed-off-by: Pavan Naregundi <pnaregundi@marvell.com>
…-net#20053)

Why I did it
This module is required in the pmon container for Storage Monitoring Daemon (stormond) to instantiate objects of type (UsbUtil)[sonic-net/sonic-platform-common#493].

Work item tracking
Microsoft ADO (number only): 29203991

How I did it
Added config to pmon Dockerfile.j2 to install blkinfo

How to verify it
On an image containing this change, verify following output:

root@str2-7050qx-32s-acs-03:/# pip3 list | grep -i blkinfo
blkinfo                       0.2.0
Upgrade credo sai package to the latest v0.9.9 to deliver a key fix from Credo to the community 
or the blackhawk phys used on Arista platform 7060dx5_64s.

ADO: 29387310
…ors (sonic-net#19164)

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>

Include unresolved neighbors when comparing APPL_DB and kernel neighbors.
…base (sonic-net#19601)

Fix sonic-net#19331

How I did it
Skip the namespace setting if the dev is DPU, because the DPU databases are only in the host namespace

How to verify it
Check there is no error log after fast-reboot

admin@vlab-01:~$ sudo cat /var/log/syslog  | grep -i asicdpu

Signed-off-by: Ze Gan <zegan@microsoft.com>
… state (sonic-net#20132)

Why I did it
This change is to restrict lossy queue buffer usage in case of congestion state.

Work item tracking
Microsoft ADO (29315559):

How I did it
Updated alpha from 0 to -4 (400g) & -5 (100g) port speed. This configuration is applied on system port and will be using HWSKU port speed settings.

How to verify it
It is verified using sonic-mgmt tests and running ok.
…atically (sonic-net#20326)

#### Why I did it
src/sonic-utilities
```
* 1d727674 - (HEAD -> 202405, origin/202405) [chassis] Modify the show ip route to hide the Ethernet-IB port in the output (sonic-net#3537) (63 minutes ago) [Arvindsrinivasan Lakshmi Narasimhan]
* 2b1177b2 - [VoQ chassis] : Script to debug packet drops (sonic-net#3536) (4 hours ago) [Vineet Mittal]
* cda43d63 - Fix multi-asic support to PFC config/show (sonic-net#3521) (4 hours ago) [HP]
* d3e99689 - [show][interface][counters] Add proposal and changes for fec-histogram for interface counters fec-histogram subcommand (sonic-net#3519) (4 hours ago) [vdahiya12]
* be6d6202 - [sfputil] Configure the debug loopback mode only on the relevant lanes of the logical port (sonic-net#3485) (4 hours ago) [Xinyu Lin]
```
#### How I did it
#### How to verify it
#### Description for the changelog
…D automatically (sonic-net#20324)

#### Why I did it
src/sonic-platform-daemons
```
* df48c7e - (HEAD -> 202405, origin/202405) [xcvrd] Add logs to improve debugging in xcvrd (sonic-net#539) (4 hours ago) [mihirpat1]
```
#### How I did it
#### How to verify it
#### Description for the changelog
… controlled ports for copper passive modules
…c-utilities sonic-platform-common sonic-platform-daemons sonic-sairedis sonic-ztp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.