Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[action] [PR:19445] fix (#19445) #19472

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

mssonicbld
Copy link
Collaborator

Why I did it
DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario.

How I did it
When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.

Why I did it
DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario.

How I did it
When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
@mssonicbld
Copy link
Collaborator Author

Original PR: #19445

@yejianquan
Copy link
Contributor

Hi @yxieca Could you help to merge this PR?
Test onboarding testcases are ignorable and not retryable, it failed because of the unstable of PR tests

@yejianquan yejianquan requested a review from yxieca July 5, 2024 03:16
@yxieca yxieca merged commit 52ed2f5 into sonic-net:202405 Jul 5, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants