[build] Use DEFAULT_CONTAINER_REGISTRY in Makefile.work instead of dockerhub. #19445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liushilongbuaa
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
|
Do we need to cherry-pick to feature branches or feature branches are using the template from the master branch? |
12 tasks
yxieca
added a commit
to yxieca/sonic-buildimage
that referenced
this pull request
Jul 3, 2024
This PR is cherry-picking sonic-net#19445 Signed-off-by: Ying Xie <ying.xie@microsoft.com>
11 tasks
|
the ms_checker was failing due to reasons unrelated to this change. @liushilongbuaa please check. |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 3, 2024
Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
|
Cherry-pick PR to 202405: #19472 |
mssonicbld
added a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jul 5, 2024
Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null. Co-authored-by: Liu Shilong <shilongliu@microsoft.com>
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Jul 17, 2024
Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
StormLiangMS
pushed a commit
that referenced
this pull request
Jul 18, 2024
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
liushilongbuaa
added a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Aug 1, 2024
Why I did it DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario. How I did it When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
DEFAULT_CONTAINER_REGISTRY didn't work as expected in some scenario.
Work item tracking
How I did it
When check for docker arch, use DEFAULT_CONTAINER_REGISTRY if it is not null.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)