[minigraph] Added support to parse "AssociatedSliceStr" attribute of minigraph #19160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peer device's Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
higher value so that BGP learnt default route is higher priority. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
save as `slice_type` as part of DEVICE_METADATA Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…graph and" This reverts commit 0f2d26d.
save as `slice_type` as part of DEVICE_METADATA for Chassis Device type Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Jun 3, 2024
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw ms_conflict |
|
@qiluo-msft , here is another minigraph parse change. can you check if you can accomodate this one? |
|
/azpw ms_conflict |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan / @qiluo-msft : please help merge of this. |
qiluo-msft
approved these changes
Jun 6, 2024
|
@bingwang-ms : can you please pick for 202405.Needed for chassis |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 12, 2024
…minigraph (sonic-net#19160) What I did: Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type. Yang model are done as part of : sonic-net#19094 Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct. Why I did: In BGP Templates we need to take different action based on this attribute. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
Cherry-pick PR to 202405: #19285 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 15, 2024
…minigraph (#19160) What I did: Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type. Yang model are done as part of : #19094 Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct. Why I did: In BGP Templates we need to take different action based on this attribute. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
arun1355492
pushed a commit
to arun1355492/sonic-buildimage
that referenced
this pull request
Jul 26, 2024
…minigraph (sonic-net#19160) What I did: Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type. Yang model are done as part of : sonic-net#19094 Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct. Why I did: In BGP Templates we need to take different action based on this attribute. Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as
slice_typeas part of DEVICE_METADATA for Chassis Device Type.Yang model are done as part of : #19094
Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.
Why I did:
In BGP Templates we need to take different action based on this attribute.
How I verify:
UT updated.