Add <fullTestName>_SET_RUN_SERIAL and use on 'ride' (#7112), fix MaxOSX install (#7881) #8063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trilinos#7112) This makes the testing workflow with TriBITS so much easiler.
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit cee1980d053ec2c26301d2389c8b0a677fa262fe Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Sat Sep 19 07:40:49 2020 -0600 Summary: Merge remote-tracking branch 'rab-github/tril-7112-run-serial' (trilinos#7112) This represents the changes in the TriBITS PRs: * TriBITSPub/TriBITS#327 : Fix install for MacOSX (trilinos#7881) * TriBITSPub/TriBITS#328 : Add support for <fullTestName>_SET_RUN_SERIAL=[ON|OFF] (trilinos#7112)
bartlettroscoe
added
type: enhancement
|
@jmgate and @e10harvey, if you do want to provide feedback and suggestions on any of the TriBITS code under
That way you can see the original commits and the extensive automated tests. |
bartlettroscoe
added a commit
that referenced
this pull request
Sep 19, 2020
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
2 similar comments
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
@jmgate and @e10harvey, can one of you review and prove this? And if you want to provide feedback on code under
Without an approved review, this can't be merged. |
e10harvey
reviewed
Sep 22, 2020
There was a problem hiding this comment.
In general, everything looks great. Please see comments in:
- Fix install for MacOSX (trilinos/Trilinos#7881) TriBITSPub/TriBITS#327
- Add support for <fullTestName>_SET_RUN_SERIAL=[ON|OFF] (trilinos/Trilinos#7112) TriBITSPub/TriBITS#328
Once TriBITSPub/TriBITS#328 (review) is addressed, I think this is ready to merge.
Thanks, Ross!!
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 362e27deddda83fb4b2c78b0d32d036da2d93965 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Tue Sep 22 10:09:42 2020 -0600 Summary: Fix stat command args for Linux (trilinos#7881) This pulls in updates from the TriBITS PR: * TriBITSPub/TriBITS#329
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 1ed38115c6b9fefe8442eb4ce7e420eb2e688ad7 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Tue Sep 22 16:06:21 2020 -0600 Summary: Generate error when trying to set install perms/group mod options on Windows (trilinos#314) Brings in changes from TriBITS PR: * TriBITSPub/TriBITS#331
|
@jmgate and @e10harvey, I think this is ready for final review and merge. Since the initial PR was created, I merged in updated snapshots from the TriBITS PRs: |
bartlettroscoe
added
AT: AUTOMERGE
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: bartlettroscoe |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
|
@ndellingwood, this PR includes changes to TriBITS to fix MaxOSX install problems. (In fact, this also makes the installation permissions and group modification code work for MacOSX.) Just waiting on someone to approve so this can be merged. |
e10harvey
reviewed
Sep 23, 2020
There was a problem hiding this comment.
@bartlettroscoe, Thanks for addressing the feedback. The fix for #7881 looks great but I spoke too soon about approving these changes.
Please see review comments and questions regarding #7112; TRIBITS_ADD_ADVANCED_TEST has a RUN_SERIAL parameter, does it need to be updated as well?
cmake/tribits/core/package_arch/TribitsAddInstallGroupAndPermsFixups.cmake
Show resolved
Hide resolved
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
|
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Sep 23, 2020
…inos#7112) This is an attempt to address review comemnts in PR trilinos/Trilinos#8063.
bartlettroscoe
added a commit
to bartlettroscoe/TriBITS
that referenced
this pull request
Sep 23, 2020
…inos#7112) This is an attempt to address review comemnts in PR trilinos/Trilinos#8063.
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ e10harvey ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 8063: IS A SUCCESS - Pull Request successfully merged |
trilinos-autotester
removed
the
AT: AUTOMERGE
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Sep 24, 2020
…s:develop' (4557faa). * trilinos-develop: Piro: fixing issue where Trapezoidal Rule Solver was not using the (trilinos#8090) Tpetra: fix warnings Tests: Fixing geminga test Phalanx: fix for gcc 5/6 lambda bug on cuda Automatic snapshot commit from tribits at 1ed3811 ATDM: ride: Tempus_IMEX_RK_Partitioned_Staggered_FSA_Partitioned_IMEX_RK_ARS_233_MPI_1 RUN_SERIAL (trilinos#7112, trilinos#8063) Fixed name Make case for output names consistent Automatic snapshot commit from tribits at 362e27d MueLu: free fine comp operator as soon as possible Automatic snapshot commit from tribits at cee1980 Allow pointing to a different TriBITS in ctest -S driver for Trilinos (trilinos#7112) ATDM: ride: Add RUN_SERIAL for several timing out tests (trilinos#7112) Zoltan2: Refactor directory to use Teuchos comm
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Sep 24, 2020
…s:develop' (4557faa). * trilinos-develop: Piro: fixing issue where Trapezoidal Rule Solver was not using the (trilinos#8090) Tpetra: fix warnings Tests: Fixing geminga test Phalanx: fix for gcc 5/6 lambda bug on cuda Automatic snapshot commit from tribits at 1ed3811 ATDM: ride: Tempus_IMEX_RK_Partitioned_Staggered_FSA_Partitioned_IMEX_RK_ARS_233_MPI_1 RUN_SERIAL (trilinos#7112, trilinos#8063) Fixed name Make case for output names consistent Automatic snapshot commit from tribits at 362e27d MueLu: free fine comp operator as soon as possible Automatic snapshot commit from tribits at cee1980 Allow pointing to a different TriBITS in ctest -S driver for Trilinos (trilinos#7112) ATDM: ride: Add RUN_SERIAL for several timing out tests (trilinos#7112) Zoltan2: Refactor directory to use Teuchos comm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings in TriBITS changes to address #7112 and #7881. This also sets the vars to add
RUN_SERIALfor the tests:which are timing out in the build:
as shown in this query.
The TriBITS changes are from the TriBITS PRs:
The TriBITS changes should be reviewed in those (merged) PRs, not here.
How was this tested?
I tested both the TriBITS and this Trilinos branch on 'ride' for the repo state and versions:
by first doing:
That showed:
and
That looks like the
RUN_SERIALproperty is getting set correctly to me.I also run the full test suite:
That submitted to CDash:
and showed the results:
There were zero timeouts. And if you look at the test history of some tests that have been randomly timing out in:
and:
you see that these two tests that were taking upwards of 8 minutes when they did not timeout that took only about 4 minutes when using RUN_SERIAL. This seems that running these tests by themselves works very well. This also means that these tests are not using the cores very independently on 'ride' for this OpenMP build on these Power8 nodes.