Generate error when trying to set install perms/group mod options on Windows (#314) #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Windows (TriBITSPub#314) This replaces logic that just ignored the instal perm/group modification options for Windows platforms added as part of Story TriBITSPub#314. Now if the user tries to set any of these options, it errors out with a (hopefully) good error message. This was flagged as part of the review of PR TriBITSPub#327.
bartlettroscoe
added a commit
to trilinos/Trilinos
that referenced
this pull request
Sep 22, 2020
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 1ed38115c6b9fefe8442eb4ce7e420eb2e688ad7 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Tue Sep 22 16:06:21 2020 -0600 Summary: Generate error when trying to set install perms/group mod options on Windows (#314) Brings in changes from TriBITS PR: * TriBITSPub/TriBITS#331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces logic that just ignored the instal perm/group modification
options for Windows platforms added as part of Story #314. Now if the user
tries to set any of these options, it errors out with a (hopefully) good error
message.
This was flagged as part of the review of PR #327.