Epetra-free build patch for issue #313 #314
Conversation
Changes were made to Stratimikos and Amesos2 to allow building without Epetra - to support a lightweight Albany build. These changes require a slight modification to Teko to cure a missing header dependency created by the above changes.
gahansen
added
type: enhancement
|
I have no issues regarding Teko at this time. |
| # Modify this to make sure that ThyraEpetraAdapters is enabled if Epetra is, and | ||
| # that ThyraTpetraAdapters is enabled if Tpetra is | ||
| IF(${PACKAGE_NAME}_ENABLE_Epetra ) | ||
| SET(${PACKAGE_NAME}_ENABLE_ThyraEpetraAdapters ON) |
There was a problem hiding this comment.
Does this logic actually work? I don't believe setting ${PROJECT_NAME}_ENABLE_<anything>=ON has any effect (at at least not the effect you want) when you set this in a <packageDir>/CMakeLists.txt. See Full TriBITS Project Configuration.
|
@gahansen, wow, is this really all you have to change to get Stratimikos to build, link, and and run correctly with Tpetra but without Epetra? |
|
@gahansen, from looking at your configure script, it does not appear that any tests are enabled. What happens when you turn the tests on for Stratimikos? Since I think that all of that automated tests for Stratimikos rely on Epetra, I suspect that there will be no tests if we update the files correctly. Another issue I just thought about is that making this change will technically break backward compatibility. That is, if there are customers that are simply enabling Straimikos with optional packages disabled, then they will not get any Epetra support for Stratimikos when they configure Trilinos. Therefore, we may need to make this change conditional and then make it flip the switch when we drop backward compatibility for Trilinos 13.0.0-dev. Therefore, we might need to protect this change in dependencies based on (perhaps) |
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 889fa648b58503cba5b4c52ec732e78f0045ef27 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Thu Apr 23 17:42:54 2020 -0600 Summary: Implement recursive chgrp and chmod for installed files/directories (#314, ATDV-241)
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 4b335ea765597db4f0bf3e77f7e0c90891635ef4 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Fri May 1 11:55:06 2020 -0600 Summary: Implement check for non-owning base dir (#314)
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 889fa648b58503cba5b4c52ec732e78f0045ef27 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Thu Apr 23 17:42:54 2020 -0600 Summary: Implement recursive chgrp and chmod for installed files/directories (trilinos#314, ATDV-241)
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 4b335ea765597db4f0bf3e77f7e0c90891635ef4 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Fri May 1 11:55:06 2020 -0600 Summary: Implement check for non-owning base dir (trilinos#314)
Origin repo remote tracking branch: 'github/master' Origin repo remote repo URL: 'github = git@github.com:TriBITSPub/TriBITS.git' At commit: commit 1ed38115c6b9fefe8442eb4ce7e420eb2e688ad7 Author: Roscoe A. Bartlett <rabartl@sandia.gov> Date: Tue Sep 22 16:06:21 2020 -0600 Summary: Generate error when trying to set install perms/group mod options on Windows (#314) Brings in changes from TriBITS PR: * TriBITSPub/TriBITS#331
Changes were made to Stratimikos and Amesos2 to allow building
without Epetra - to support a lightweight Albany build.
These changes require a slight modification to Teko to cure a missing
header dependency created by the above changes.
The matching Trilinos cmake script is also included.