-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Piro: fixing issue where Trapezoidal Rule Solver #8090
Conversation
…_000614 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200724_000614 branch to master PR Author: trilinos-autotester
…_000609 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200725_000609 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200728_000610 branch to master PR Author: trilinos-autotester
…_000613 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200730_000613 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200731_000610 branch to master PR Author: trilinos-autotester
…_000608 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200801_000608 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200803_000610 branch to master PR Author: trilinos-autotester
…_000613 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200804_000613 branch to master PR Author: trilinos-autotester
…_000612 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200805_000612 branch to master PR Author: trilinos-autotester
…_000614 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200806_000614 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200807_000610 branch to master PR Author: trilinos-autotester
…_000612 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200808_000612 branch to master PR Author: trilinos-autotester
…_000611 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200810_000611 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200811_000610 branch to master PR Author: trilinos-autotester
…_000616 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200812_000616 branch to master PR Author: trilinos-autotester
…_000611 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200819_000611 branch to master PR Author: trilinos-autotester
…_000624 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200820_000624 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200821_000610 branch to master PR Author: trilinos-autotester
…_000620 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200822_000620 branch to master PR Author: trilinos-autotester
…_000609 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200824_000609 branch to master PR Author: trilinos-autotester
…_000614 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200825_000614 branch to master PR Author: trilinos-autotester
…_000611 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200826_000611 branch to master PR Author: trilinos-autotester
…_000609 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200828_000609 branch to master PR Author: trilinos-autotester
…_000611 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200901_000611 branch to master PR Author: trilinos-autotester
…_000612 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200902_000612 branch to master PR Author: trilinos-autotester
…_000608 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200903_000608 branch to master PR Author: trilinos-autotester
…_000609 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200904_000609 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200905_000610 branch to master PR Author: trilinos-autotester
…_000609 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200909_000609 branch to master PR Author: trilinos-autotester
…_000614 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200910_000614 branch to master PR Author: trilinos-autotester
…_000614 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200911_000614 branch to master PR Author: trilinos-autotester
…_000608 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200912_000608 branch to master PR Author: trilinos-autotester
…_000608 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200915_000608 branch to master PR Author: trilinos-autotester
…_000614 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200916_000614 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200918_000610 branch to master PR Author: trilinos-autotester
…_000610 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200919_000610 branch to master PR Author: trilinos-autotester
…_000611 Automatically Merged using Trilinos Master Merge AutoTester PR Title: Trilinos Master Merge PR Generator: Auto PR created to promote from master_merge_20200922_000611 branch to master PR Author: trilinos-autotester
convergence criteria passed in from the input file, such as max # of nonlinear iterations.
Looks good to me. Small change. Thanks for hunting this down! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
Using Repos:
Pull Request Author: ikalash |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0_debug
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_clang_10.0.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_2
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_python_3
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ lxmota ]! |
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
…s:develop' (4557faa). * trilinos-develop: Piro: fixing issue where Trapezoidal Rule Solver was not using the (trilinos#8090) Tpetra: fix warnings Tests: Fixing geminga test Phalanx: fix for gcc 5/6 lambda bug on cuda Automatic snapshot commit from tribits at 1ed3811 ATDM: ride: Tempus_IMEX_RK_Partitioned_Staggered_FSA_Partitioned_IMEX_RK_ARS_233_MPI_1 RUN_SERIAL (trilinos#7112, trilinos#8063) Fixed name Make case for output names consistent Automatic snapshot commit from tribits at 362e27d MueLu: free fine comp operator as soon as possible Automatic snapshot commit from tribits at cee1980 Allow pointing to a different TriBITS in ctest -S driver for Trilinos (trilinos#7112) ATDM: ride: Add RUN_SERIAL for several timing out tests (trilinos#7112) Zoltan2: Refactor directory to use Teuchos comm
…s:develop' (4557faa). * trilinos-develop: Piro: fixing issue where Trapezoidal Rule Solver was not using the (trilinos#8090) Tpetra: fix warnings Tests: Fixing geminga test Phalanx: fix for gcc 5/6 lambda bug on cuda Automatic snapshot commit from tribits at 1ed3811 ATDM: ride: Tempus_IMEX_RK_Partitioned_Staggered_FSA_Partitioned_IMEX_RK_ARS_233_MPI_1 RUN_SERIAL (trilinos#7112, trilinos#8063) Fixed name Make case for output names consistent Automatic snapshot commit from tribits at 362e27d MueLu: free fine comp operator as soon as possible Automatic snapshot commit from tribits at cee1980 Allow pointing to a different TriBITS in ctest -S driver for Trilinos (trilinos#7112) ATDM: ride: Add RUN_SERIAL for several timing out tests (trilinos#7112) Zoltan2: Refactor directory to use Teuchos comm
The Piro::TrapezoidalRuleSolver was not using the non-linear solver criteria passed in from the input file, such as max #
of nonlinear iterations. This PR fixes this issue.