Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: rename LeaderScheduleStrategy to LeaderSchedulePolicy #2075

Merged
merged 2 commits into from
Jan 3, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 2, 2020

What problem does this PR solve?

PR #2065 introduces a compatible problem. Consider that change is not released, we omit the compatible problem. But actually, there are still some tests that rely on the master branch. Closes #2072.

What is changed and how it works?

This PR rename LeaderScheduleStrategy to LeaderSchedulePolicy.

Check List

Tests

  • Unit test

@rleungx rleungx added the DNM label Jan 2, 2020
@codecov-io
Copy link

codecov-io commented Jan 2, 2020

Codecov Report

Merging #2075 into master will decrease coverage by 0.13%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2075      +/-   ##
==========================================
- Coverage    76.9%   76.76%   -0.14%     
==========================================
  Files         191      191              
  Lines       19293    19293              
==========================================
- Hits        14837    14810      -27     
- Misses       3346     3362      +16     
- Partials     1110     1121      +11
Impacted Files Coverage Δ
server/schedule/selector/selector.go 95.78% <100%> (ø) ⬆️
server/core/store.go 78.62% <100%> (ø) ⬆️
server/config/config.go 89.47% <100%> (ø) ⬆️
server/schedulers/utils.go 88.82% <100%> (ø) ⬆️
server/cluster/cluster.go 81.31% <100%> (ø) ⬆️
pkg/mock/mockoption/mockoption.go 95.74% <100%> (ø) ⬆️
server/schedule/operator_controller.go 82.35% <100%> (+0.17%) ⬆️
server/schedule/operator/influence.go 80% <100%> (ø) ⬆️
server/schedule/checker/merge_checker.go 70.73% <100%> (ø) ⬆️
server/schedulers/balance_leader.go 90.84% <100%> (ø) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ebe3f8...2b8f179. Read the comment docs.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx rleungx changed the title config: change default strategy to size config: rename LeaderScheduleStrategy to LeaderSchedulePolicy Jan 3, 2020
@rleungx rleungx added component/config Configuration logic. and removed DNM labels Jan 3, 2020
@nolouch
Copy link
Contributor

nolouch commented Jan 3, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 3, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jan 3, 2020

/run-all-tests

@sre-bot sre-bot merged commit c32c3d5 into tikv:master Jan 3, 2020
lhy1024 added a commit to lhy1024/pd that referenced this pull request May 29, 2020
Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/config Configuration logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unstable performance of sysbench oltp_update_index benchmarking
5 participants