-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: rename LeaderScheduleStrategy to LeaderSchedulePolicy #2075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2075 +/- ##
==========================================
- Coverage 76.9% 76.76% -0.14%
==========================================
Files 191 191
Lines 19293 19293
==========================================
- Hits 14837 14810 -27
- Misses 3346 3362 +16
- Partials 1110 1121 +11
Continue to review full report at Codecov.
|
Signed-off-by: Ryan Leung <rleungx@gmail.com>
rleungx
changed the title
config: change default strategy to size
config: rename LeaderScheduleStrategy to LeaderSchedulePolicy
Jan 3, 2020
lhy1024
approved these changes
Jan 3, 2020
nolouch
approved these changes
Jan 3, 2020
/merge |
sre-bot
added
the
status/can-merge
Indicates a PR has been approved by a committer.
label
Jan 3, 2020
/run-all-tests |
3 tasks
lhy1024
added a commit
to lhy1024/pd
that referenced
this pull request
May 29, 2020
Signed-off-by: lhy1024 <admin@liudos.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/config
Configuration logic.
status/can-merge
Indicates a PR has been approved by a committer.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
PR #2065 introduces a compatible problem. Consider that change is not released, we omit the compatible problem. But actually, there are still some tests that rely on the master branch. Closes #2072.
What is changed and how it works?
This PR rename
LeaderScheduleStrategy
toLeaderSchedulePolicy
.Check List
Tests