Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstable performance of sysbench oltp_update_index benchmarking #2072

Closed
mahjonp opened this issue Jan 1, 2020 · 3 comments · Fixed by #2075
Closed

Unstable performance of sysbench oltp_update_index benchmarking #2072

mahjonp opened this issue Jan 1, 2020 · 3 comments · Fixed by #2075
Labels
type/bug The issue is confirmed as a bug.

Comments

@mahjonp
Copy link

mahjonp commented Jan 1, 2020

  1. What did you do?

PR #2065 may Introduced a bug that cause the unstable performance of oltp_update_index workload.

image

You can reproduce it with sysbench running oltp_update_index method with master tidb, master tikv and pd commit hash: 26ba96d

sysbench oltp_update_index --mysql-host=127.0.0.1 --mysql-port=4000 --mysql-user=root --mysql-db=sbtest --time=240 --mysql-ignore-errors=all --report-interval=10 --db-driver=mysql --threads=256 --percentile=99 --warmup-time=60 --rand-type=special --tables=32 --table-size=1000000 run
@mahjonp mahjonp added the type/bug The issue is confirmed as a bug. label Jan 1, 2020
@disksing
Copy link
Contributor

disksing commented Jan 2, 2020

@mahjonp It is very unlikely that this PR has performance issue. I wonder how did you nail down to this PR...
/cc @rleungx

@mahjonp
Copy link
Author

mahjonp commented Jan 2, 2020

@mahjonp It is very unlikely that this PR has performance issue. I wonder how did you nail down to this PR...
/cc @rleungx

You could see that the performance was stable in b361283, but it became unstable from 26ba96d, so it's obvious that the problem was Introduced in 26ba96d 🤣.

8d883e5:https://internal.pingcap.net/idc-jenkins/view/bench_bot/job/bench_sysbench_per_pr/839/consoleFull
26ba96d: https://internal.pingcap.net/idc-jenkins/view/bench_bot/job/bench_sysbench_per_pr/841/consoleFull
b361283: https://internal.pingcap.net/idc-jenkins/view/bench_bot/job/bench_sysbench_per_pr/838/consoleFull

@rleungx
Copy link
Member

rleungx commented Jan 2, 2020

PR #2065 only changes the config output problem, which is not related to performance. @mahjonp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants