config: tiny fix config item #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Leung <rleungx@gmail.com>
lhy1024
approved these changes
Dec 30, 2019
overvenus
approved these changes
Dec 31, 2019
overvenus
added
the
status/can-merge
|
/run-all-tests |
disksing
approved these changes
Dec 31, 2019
|
/merge |
Codecov Report
@@ Coverage Diff @@
## master #2065 +/- ##
=========================================
Coverage ? 76.68%
=========================================
Files ? 190
Lines ? 19276
Branches ? 0
=========================================
Hits ? 14781
Misses ? 3368
Partials ? 1127
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
when using pd-ctl config show:
before:
After:
What is changed and how it works?
This PR removes the "string" tag for
LeaderScheduleStrategy.Check List
Tests