Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add balance leader score option for release 3.0 #2479

Merged
merged 6 commits into from
May 29, 2020
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented May 29, 2020

Signed-off-by: lhy1024 admin@liudos.us

What problem does this PR solve?

Check List

Tests

  • Unit test

Release note

Add balance leader score option, It will be allowed to count leader score according to size or count.

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 added the component/scheduler Scheduler logic. label May 29, 2020
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 29, 2020

/run-all-tests

@lhy1024 lhy1024 changed the title Add balance leader score for release 3.0 Add balance leader score option for release 3.0 May 29, 2020
Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024 lhy1024 added this to the v3.0.15 milestone May 29, 2020
@lhy1024 lhy1024 requested review from rleungx and nolouch May 29, 2020 09:09
Signed-off-by: lhy1024 <admin@liudos.us>
server/config.go Outdated Show resolved Hide resolved
@rleungx rleungx self-requested a review May 29, 2020 09:39
Co-authored-by: ShuNing <nolouch@gmail.com>
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 29, 2020

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented May 29, 2020

Codecov Report

Merging #2479 into release-3.0 will decrease coverage by 0.05%.
The diff coverage is 92.85%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-3.0    #2479      +/-   ##
===============================================
- Coverage        69.92%   69.86%   -0.06%     
===============================================
  Files              171      171              
  Lines            16896    16983      +87     
===============================================
+ Hits             11814    11866      +52     
- Misses            4120     4145      +25     
- Partials           962      972      +10     
Impacted Files Coverage Δ
server/core/resource_kind.go 78.57% <80.00%> (+3.57%) ⬆️
server/core/store.go 76.17% <81.81%> (-0.22%) ⬇️
server/schedulers/balance_region.go 89.51% <83.33%> (+5.14%) ⬆️
server/schedule/operator_controller.go 87.03% <84.61%> (-0.16%) ⬇️
pkg/mock/mockcluster/mockcluster.go 90.68% <100.00%> (+0.17%) ⬆️
pkg/mock/mockoption/mockoption.go 92.77% <100.00%> (+0.27%) ⬆️
server/api/store.go 54.88% <100.00%> (ø)
server/cluster_info.go 88.38% <100.00%> (+0.04%) ⬆️
server/config.go 83.37% <100.00%> (+0.22%) ⬆️
server/core/test_util.go 94.73% <100.00%> (+1.87%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf8065e...0e0601e. Read the comment docs.

Signed-off-by: lhy1024 <admin@liudos.us>
@lhy1024
Copy link
Contributor Author

lhy1024 commented May 29, 2020

/run-integration-common-test

@lhy1024
Copy link
Contributor Author

lhy1024 commented May 29, 2020

/run-all-tests

@lhy1024
Copy link
Contributor Author

lhy1024 commented May 29, 2020

/run-test

@lhy1024
Copy link
Contributor Author

lhy1024 commented May 29, 2020

/run-all-tests

@rleungx
Copy link
Member

rleungx commented May 29, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 29, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 29, 2020

/run-all-tests

@sre-bot sre-bot merged commit d0963de into tikv:release-3.0 May 29, 2020
@lhy1024 lhy1024 deleted the r3 branch May 29, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants