Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

fix typo in localization util.launch.py #168

Merged
merged 1 commit into from
Jan 23, 2022
Merged

fix typo in localization util.launch.py #168

merged 1 commit into from
Jan 23, 2022

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented Jan 18, 2022 •
edited by wep21
Loading

PR Type

  • Bug Fix

Related Links

Description

RandomDownsampleFilter should have been launched, but VoxelGridDownsampleFilter was launched by mistake.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code follows coding guidelines
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@YamatoAndo YamatoAndo mentioned this pull request Jan 21, 2022
Merged
7 tasks
@YamatoAndo YamatoAndo requested a review from wep21 January 21, 2022 07:54
RyuYamamoto
RyuYamamoto approved these changes Jan 22, 2022
View reviewed changes
Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wep21 wep21 merged commit 3edf482 into tier4/universe Jan 23, 2022
@wep21 wep21 deleted the fix/localization_util_launch_typo branch January 23, 2022 06:30
kazuki527 pushed a commit to kazuki527/autoware_launch that referenced this pull request Apr 25, 2022
@h-ohta
feat: enable map diag (tier4#168)
b148519
takayuki5168 pushed a commit that referenced this pull request May 26, 2022
Revert "Add diagnostics list to api_launch (#164)" (#168)
cd65b0c
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@tier4-autoware-private-bot @tkimura4
@rej55 @YamatoAndo @dependabot @kenji-miyake @yabuta @tier4-autoware-public-bot @pre-commit-ci @wep21 @zulfaqar-azmi-t4 @taikitanaka3 @h-ohta @yukkysaito @takayuki5168
sync upstream (#206)
cb7edec 
* update parameter (#169)

* Port pure pursuit (#166)

* Fix control.launch.py

* Apply pre-commit

* Fix control.launch.py

* Change debug topic name in rviz setting

* fix typo in localization util.launch.py (#168)

* Feature/add covarinace param (#170)

* add covariance param

* add description

* remove unused param (#172)

* Bump streetsidesoftware/cspell-action from 1.3.4 to v1 (#174)

* Bump streetsidesoftware/cspell-action from 1.3.4 to 1.5.0

Bumps [streetsidesoftware/cspell-action](https://github.com/streetsidesoftware/cspell-action) from 1.3.4 to 1.5.0.
- [Release notes](https://github.com/streetsidesoftware/cspell-action/releases)
- [Changelog](https://github.com/streetsidesoftware/cspell-action/blob/main/CHANGELOG.md)
- [Commits](streetsidesoftware/cspell-action@v1.3.4...v1.5.0)

---
updated-dependencies:
- dependency-name: streetsidesoftware/cspell-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* Update spell_check_pr.yml

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix: fix hdd_monitor param (#173)

* add rosbridge launch (#175)

* add rosbridge launch

* fix TODO document

add link to pull request

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix double-byte character

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#177)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* ci: update CI settings (#176)

* ci(pre-commit): update .pre-commit-config.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci: add sync-files.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: remove old workflows

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(sync-upstream): update sync-upstream.yaml

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* ci(pre-commit): autofix

* style: fix for yamllint

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: minor update CI settings (#179)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* [pre-commit.ci] pre-commit autoupdate (#178)

updates:
- [github.com/pre-commit/pre-commit-hooks: v4.0.1 → v4.1.0](pre-commit/pre-commit-hooks@v4.0.1...v4.1.0)
- [github.com/igorshubovych/markdownlint-cli: v0.29.0 → v0.30.0](igorshubovych/markdownlint-cli@v0.29.0...v0.30.0)
- [github.com/pre-commit/mirrors-prettier: v2.4.1 → v2.5.1](pre-commit/mirrors-prettier@v2.4.1...v2.5.1)
- [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1)
- [github.com/psf/black: 21.9b0 → 22.1.0](psf/black@21.9b0...22.1.0)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: fix CI settings (#182)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* chore: sync files (#180)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#184)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat: add paricle param (#181)

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* chore: sync files (#185)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* Update sync-files.yaml

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* chore: sync files (#186)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync system config (#187)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* chore: sync files (#189)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: wep21 <wep21@users.noreply.github.com>

* chore: replace system config in system launch (#188)

Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>

* feat: adds additional configuration flags for behavior_path_planner (#171)

* feat: adds additional configuration flags for behavior_path_planner

The additional configuration is used to allows avoidance over lane with same and
different direction, as well as allows safety margin between linestring and ego.

This is a `.iv` launcher https://github.com/tier4/autoware_launcher/pull/496
port.

Related PR:
autowarefoundation/autoware.universe#285
autowarefoundation/autoware.universe#287

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Change lateral_collision_margion to 1.0 to reflect changes.

The decision to change the parameter value to 1.0 is made after performing
drivable area experiment at Odaiba areas on 2nd of February 2022 and meeting
between planning control team on 3rd of February 2022.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* fix: slightly increase the safety buffer.

This increases the shift length to 1.7 + 0.5 * vehicle width.

The decision to increase is based on the discussion between planning team and
also the advice from the FI team.

Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* feat(behavior_velocity): add path marker visualization (#190)

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: sync files (#193)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: sync files (#194)

* chore: sync files

Signed-off-by: GitHub <noreply@github.com>

* chore: update workflow files name

Signed-off-by: h-ohta <hiroki.ota@tier4.jp>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>

* chore: sync files (#195)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>

* feat: lateral controller param (#191)

* feat: define lat_controller_param_path

* feat: change for trajectory_follower params

* add args for lat_controller_param_path

* chore: fix wrong essential param to optional (#197)

* fix wrong param line

* move pointcloud_container_name param to optional

* fix: typo extra `>` (#199)

* Chore arrange perception rviz topics (#196)

* feat(autoware_launch): add occupancy grid vizualization

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* feat(autoware_launch): add object recognition namespace to rviz

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: delete unused in control_launch (#200)

* fix: delete unused in control.launch.py

* fix: delete velocity_controller.param.yaml

* feat: add system_monitor parameters in sync-files (#201)

* chore: sync files (#202)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>

* chore: sync files (#203)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* chore: update settings of sync-files (#204)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>

* feat(control_launch): remove unnecessary params (#206)

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* chore: sync files (#208)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* feat(atutoware.rviz): disable selectable for pointcloud visualization (#207)

Signed-off-by: YamatoAndo <yamato.ando@gmail.com>

* chore: sync files (#212)

Signed-off-by: GitHub <noreply@github.com>

Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>

* delete vehicle parameters in longitudinal_controller.param.yaml

* apply pre-commit

* remove unused file

* update sync-param-files.yaml

* disable local_external_control in system_error_montitor_psim

Co-authored-by: Tomoya Kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Fumiya Watanabe <rej55.g@gmail.com>
Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Co-authored-by: yabuta <makoto.yabuta@tier4.jp>
Co-authored-by: tier4-autoware-bot[bot] <98652886+tier4-autoware-bot[bot]@users.noreply.github.com>
Co-authored-by: kenji-miyake <kenji-miyake@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Daisuke Nishimatsu <42202095+wep21@users.noreply.github.com>
Co-authored-by: wep21 <wep21@users.noreply.github.com>
Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com>
Co-authored-by: taikitanaka3 <65527974+taikitanaka3@users.noreply.github.com>
Co-authored-by: tier4-autoware-public-bot[bot] <98652886+tier4-autoware-public-bot[bot]@users.noreply.github.com>
Co-authored-by: h-ohta <h-ohta@users.noreply.github.com>
Co-authored-by: h-ohta <hiroki.ota@tier4.jp>
Co-authored-by: Yukihiro Saito <yukky.saito@gmail.com>
Co-authored-by: Takayuki Murooka <takayuki5168@gmail.com>
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@tkimura4 @YamatoAndo
@yabuta @kenji-miyake
Sync/beta/v0.30.0.0 (#209)
d5a6952 
* change parameters of longitudinal controller
(tier4/autoware_launch.xx1#202)

* fix typo in localization util.launch.py (#168)

* add rosbridge launch (#175)

* add rosbridge launch

* fix TODO document

add link to pull request

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

* fix double-byte character

Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>

Co-authored-by: YamatoAndo <yamato.ando@gmail.com>
Co-authored-by: yabuta <makoto.yabuta@tier4.jp>
Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
maxime-clem pushed a commit that referenced this pull request May 27, 2022
@YamatoAndo
fix typo in localization util.launch.py (#168)
0d12764
kosuke55 added a commit that referenced this pull request Jan 17, 2023
@kosuke55
feat(behavior_path_planner): add option for combining arc pull out pa…
7d393a7 
…ths (#168)

* feat(behavior_path_planner): add option for combining arc pull out paths

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* divide_pull_out_path

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
This was referenced Jan 21, 2023
Merged
Merged
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RyuYamamoto RyuYamamoto RyuYamamoto approved these changes

@yukkysaito yukkysaito Awaiting requested review from yukkysaito

@wep21 wep21 Awaiting requested review from wep21

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YamatoAndo @RyuYamamoto @wep21